After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726343 - Use header bars in dialogs
Use header bars in dialogs
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
3.11.x
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-03-14 13:56 UTC by Debarshi Ray
Modified: 2014-03-17 09:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
selections: Handle the sharing dialog being deleted (1000 bytes, patch)
2014-03-14 14:18 UTC, Debarshi Ray 		committed Details | Review
Use header bars in dialogs (4.13 KB, patch)
2014-03-14 14:24 UTC, Debarshi Ray 		committed Details | Review
places: Use the builtin GtkHeaderBar in GtkDialog instead of our own (2.05 KB, patch)
2014-03-14 14:40 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2014-03-14 13:56:32 UTC 
We should switch to using header bars in dialogs for consistency with the other core applications.
Comment 1 Debarshi Ray 2014-03-14 14:18:40 UTC 
Created attachment 271896 [details] [review]
selections: Handle the sharing dialog being deleted
Comment 2 Debarshi Ray 2014-03-14 14:24:21 UTC 
Created attachment 271898 [details] [review]
Use header bars in dialogs
Comment 3 Debarshi Ray 2014-03-14 14:40:01 UTC 
Created attachment 271903 [details] [review]
places: Use the builtin GtkHeaderBar in GtkDialog instead of our own
Comment 4 Cosimo Cecchi 2014-03-14 17:31:05 UTC 
Review of attachment 271896 [details] [review]:

Looks good
Comment 5 Cosimo Cecchi 2014-03-14 17:31:41 UTC 
Review of attachment 271898 [details] [review]:

Looks good - do we need an UI freeze break request for this?
Comment 6 Cosimo Cecchi 2014-03-14 17:32:22 UTC 
Review of attachment 271903 [details] [review]:

Looks good
Comment 7 Debarshi Ray 2014-03-15 08:13:42 UTC 
(In reply to comment #5)
> Review of attachment 271898 [details] [review]:
> 
> Looks good - do we need an UI freeze break request for this?

Yes. I have asked for permission.