After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727094 - Port sidebars to GtkListBox
Port sidebars to GtkListBox
Status: RESOLVED OBSOLETE
Product: gnome-music
Classification: Applications
Component: general
3.13.x
Other All
: Low enhancement
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2014-03-26 15:02 UTC by Simen Heggestøyl
Modified: 2018-01-10 14:39 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Simen Heggestøyl 2014-03-26 15:02:09 UTC
Using the arrow keys to move around in Artists view highlights the artists, but they are not focused, so the album list doesn't update.

Artists are focused when they are mouse clicked. I would really like arrow key movements to focus the artist as well, making it easier to browse their albums using the keyboard.

This functionality is already present in other music players, such as Rhythmbox and Quod Libet.
Comment 1 Vadim Rutkovsky 2014-03-26 20:25:11 UTC
Thats debatable, <Enter> works for choosing artists. Displaying artist albums might take some time (keeping in mind that albums might be situated on remote sources), so an extra click / <Enter> press doesn't hurt.

Allan, what's your opinion on this?
Comment 2 Allan Day 2014-04-22 15:18:56 UTC
(In reply to comment #1)
> Thats debatable, <Enter> works for choosing artists. Displaying artist albums
> might take some time (keeping in mind that albums might be situated on remote
> sources), so an extra click / <Enter> press doesn't hurt.

That doesn't seem like a huge deal to me. If that's the artist you are interested in, you will have to wait anyway. If you're not interested in that artist, you can just move on.

> Allan, what's your opinion on this?

I agree with the bug reporter. I don't think there's a distinction between focused and selected in this case.
Comment 3 Arnel Borja 2014-04-22 16:32:07 UTC
I suggest we replace the GtkTreeView used in the sidebars of Artists and Playlists view with GtkListBox, which has the focused item as the selected item too in single selection mode (that's how GNOME Tweak Tool works...).

Other GNOME Core Apps uses GtkListBox for sidebars anyway, and we currently require GTK+ 3.10 which introduced this widget.

That would probably fix bug 723144 too, two birds with one stone :D
Comment 4 Vadim Rutkovsky 2014-04-22 19:45:32 UTC
(In reply to comment #3)
> Other GNOME Core Apps uses GtkListBox for sidebars anyway, and we currently
> require GTK+ 3.10 which introduced this widget.
> 
> That would probably fix bug 723144 too, two birds with one stone :D
+1, let start with porting to GtkListBox
Comment 5 Allan Day 2016-01-06 13:11:40 UTC
Bulk removing the 3.18 target.
Comment 6 Allan Day 2016-01-06 13:16:40 UTC
Removing the available whiteboard - we're not really using it any more.
Comment 7 GNOME Infrastructure Team 2018-01-10 14:39:09 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-music/issues/18.