After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725531 - [patch] gimp doesn't build in stable modulesets
[patch] gimp doesn't build in stable modulesets
Status: RESOLVED OBSOLETE
Product: gtk-osx
Classification: Other
Component: General
unspecified
Other Mac OS
: Normal normal
: ---
Assigned To: GTK Mac Integration Maintainers
GTK Mac Integration Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-03-02 23:59 UTC by Brion Vibber
Modified: 2015-02-23 20:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch against gimp to fix build of 2.8.10 (413 bytes, patch)
2014-03-02 23:59 UTC, Brion Vibber
none Details | Review
Update of module definition to gimp 2.8.10, adds patch (1.29 KB, patch)
2014-03-03 00:03 UTC, Brion Vibber
needs-work Details | Review

Description Brion Vibber 2014-03-02 23:59:18 UTC
Created attachment 270734 [details] [review]
Patch against gimp to fix build of 2.8.10

Stable moduleset currently has gimp 2.8.2 which is fairly old, and no longer builds with the current provided version of freetype:

  gimpfont.c:30:10: fatal error: 'freetype/tttables.h' file not found
  #include <freetype/tttables.h>
           ^

per https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=732010 freetype has changed and gimp to use the proper #define instead of hardcoding the name of this file.

I can also confirm that going ahead and updating to 2.8.10 works, but still needs a patch.
Comment 1 Brion Vibber 2014-03-03 00:03:24 UTC
Created attachment 270735 [details] [review]
Update of module definition to gimp 2.8.10, adds patch

Change the patch path to the final path when applying, of course. :)

Note that to actually build gimp it's also necessary to fix babl -- workaround on bug 725530
Comment 2 su-v 2014-03-04 14:04:16 UTC
Tracked for GIMP in bug #719560 (fix was also committed to the stable branch gimp-2-8, but after the release of 2.8.10).
Comment 3 John Ralls 2014-03-06 17:33:46 UTC
Comment on attachment 270735 [details] [review]
Update of module definition to gimp 2.8.10, adds patch
Comment 4 John Ralls 2014-03-06 17:41:52 UTC
A patch file pointing to your user directory works only for you. Don't feel bad, I've made that mistake too.

For reference, see Gimp bug 719560; Mitch's actual patch is https://git.gnome.org/browse/gimp/patch/?id=71c144c972d5582522b6d13a4194169916186c7a. The best solution is to use that URI and to add a comment saying that it will be in 2.8.11 so that I remember to take it out the next time I upgrade the gimp version.
Comment 5 John Ralls 2015-02-23 20:30:25 UTC
Gimp is now at 2.8.14, and I'm updating the modulesets accordingly.