GNOME Bugzilla – Bug 719560
Build failure with freetype 2.5.1
Last modified: 2013-11-29 21:03:43 UTC
Created attachment 263129 [details] [review] fix includes for freetype GIMP 2.8.10 fails to build with just released freetype 2.5.1, which has changed the header file layout: <quote> - The header file layout has been changed. After installation, all files are now located in `<prefix>/include/freetype2'. Applications that use (a) `freetype-config' or FreeType's `pkg-config' file to get the include directory for the compiler, and (b) the documented way for header inclusion like #include <ft2build.h> #include FT_FREETYPE_H ... don't need any change to the source code. </quote> <http://lists.nongnu.org/archive/html/freetype-announce/2013-11/msg00001.html> According to <http://www.freetype.org/freetype2/docs/tutorial/step1.html> the attached proposed patch should be backwards-compatible with Freetype >= 2.1.6.
Relevant snippet from build log: :info:build CC gimpfont.o :info:build CC gimp-fonts.o :info:build CC gimpfontlist.o :info:build CC gimptext.o :info:build gimpfont.c:30:10: fatal error: 'freetype/tttables.h' file not found :info:build #include <freetype/tttables.h> :info:build ^ :info:build CC gimptext-compat.o :info:build 1 error generated. :info:build make[4]: *** [gimpfont.o] Error 1 :info:build make[4]: *** Waiting for unfinished jobs.... Patch was tested with GIMP 2.8.10 on OS X 10.7.5
I was under the impression we did this correctly, but maybe that was when we were still using freetype directly. I you have commit access, please push to master and gimp-2-8.
@mitch - I don't have commit access.
If you had a real name I could credit you in the commit...
@mitch - as long as gnome.org's AccountNamePolicy doesn't extend to (existing) bugzilla accounts, I'll rather keep using a nick ;)
Very well :) Fixed in master and gimp-2-8: commit 71c144c972d5582522b6d13a4194169916186c7a Author: Michael Natterer <mitch@gimp.org> Date: Fri Nov 29 21:57:46 2013 +0100 Bug 719560 - Build failure with freetype 2.5.1 Apply patch from su-v that fixes the freetype include to the madness devised and recommended by freetype. (cherry picked from commit 6c73f28b6d87a2afd11974552a075bffec52347f) app/text/gimpfont.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)