After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724676 - Add a version information API
Add a version information API
Status: RESOLVED FIXED
Product: libgweather
Classification: Core
Component: general
unspecified
Other Linux
: Normal enhancement
: future
Assigned To: libgweather-maint
libgweather-maint
Depends on:
Blocks: 723928
 
 
Reported: 2014-02-18 17:38 UTC by Matthew Barnes
Modified: 2014-02-19 14:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add version information API (7.44 KB, patch)
2014-02-19 13:58 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Matthew Barnes 2014-02-18 17:38:53 UTC 
libgweather lacks a version information API similar to GLib [1] and GTK+ [2], particularly a "GWEATHER_CHECK_VERSION" macro which would be useful for working around deprecation warnings or conditionally using new features.

[1] https://developer.gnome.org/glib/stable/glib-Version-Information.html
[2] https://developer.gnome.org/gtk3/stable/gtk3-Feature-Test-Macros.html
Comment 1 Javier Jardón (IRC: jjardon) 2014-02-19 13:58:07 UTC 
Created attachment 269678 [details] [review]
Add version information API
Comment 2 Giovanni Campagna 2014-02-19 14:15:46 UTC 
Review of attachment 269678 [details] [review]:

Looks good!
Comment 3 Javier Jardón (IRC: jjardon) 2014-02-19 14:34:39 UTC 
Comment on attachment 269678 [details] [review]
Add version information API

commit 7fd8ce84126d66e0c05a8c6ad83e281b70790fd0
Author: Javier Jardón <javier.jardon@codethink.co.uk>
Date:   Tue Feb 18 22:31:01 2014 +0000

    Add version information API
    
    Fixes bug https://bugzilla.gnome.org/show_bug.cgi?id=724676

Thanks for the review!
Comment 4 Javier Jardón (IRC: jjardon) 2014-02-19 14:34:53 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.