After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723928 - Weather backend: Replace two deprecated gweather_* functions
Weather backend: Replace two deprecated gweather_* functions
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Calendar
3.11.x (obsolete)
Other Linux
: Normal minor
: ---
Assigned To: evolution-calendar-maintainers
Evolution QA team
evolution[cleanup]
Depends on: 724676
Blocks:
 
 
Reported: 2014-02-08 21:48 UTC by André Klapper
Modified: 2015-04-07 14:04 UTC
See Also:
GNOME target: ---
GNOME version: 3.11/3.12



Description André Klapper 2014-02-08 21:48:38 UTC
1) gchar* gweather_info_get_forecast() was removed in https://git.gnome.org/browse/libgweather/commit/?id=2e3ae2b410af07c7eedb7ef16dce684d012a80f8 and superseded by GSList* gweather_info_get_forecast_list(). 
Both functions have been available at least since 3.6, see https://developer.gnome.org/libgweather/3.6/libgweather-GWeatherInfo.html#gweather-info-get-forecast

make[4]: Entering directory `/run/media/andre/linux/git/gnome/evolution-data-server/calendar/backends/weather'
e-cal-backend-weather.c: In function 'create_weather':
e-cal-backend-weather.c:438:2: warning: 'gweather_info_get_forecast' is deprecated (declared at /run/media/andre/linux/builds/gnome/include/libgweather-3.0/libgweather/gweather-weather.h:102): Use 'gweather_info_get_forecast_list' instead [-Wdeprecated-declarations]
  tmp = gweather_info_get_forecast (report);
  ^


2) GWeatherLocation* gweather_location_new_world(): https://developer.gnome.org/libgweather/3.6/GWeatherLocation.html#gweather-location-new-world
was removed for 3.10 in https://git.gnome.org/browse/libgweather/commit/?id=d5332e605a297f4ec402ea323946193962a4ed33 by replacing it by
GWeatherLocation* gweather_location_get_world() since 3.10:
https://developer.gnome.org/libgweather/3.10/GWeatherLocation.html#gweather-location-get-world

e-weather-source.c: In function 'e_weather_source_new':
e-weather-source.c:124:2: warning: 'gweather_location_new_world' is deprecated (declared at /run/media/andre/linux/builds/gnome/include/libgweather-3.0/libgweather/gweather-location.h:54): Use 'gweather_location_get_world' instead [-Wdeprecated-declarations]
  world = gweather_location_new_world (FALSE);
  ^
make[4]: Leaving directory `/run/media/andre/linux/git/gnome/evolution-data-server/calendar/backends/weather'
Comment 1 Matthew Barnes 2014-02-18 17:40:31 UTC
Since libgweather lacks version information macros similar to GLIB_CHECK_VERSION, which allow for conditional compilation, I think we'll live with the deprecation warnings until we have a more compelling reason to bump the dependency.

I filed bug 724676 for gweather to add version macros.
Comment 2 Milan Crha 2015-04-07 14:04:44 UTC
Created commit 149d588 in eds master (3.17.1+)