GNOME Bugzilla – Bug 723204
Evolution account assistant (and many other dialogs) too wide due to regression introduced in GTK commit f18655c6
Last modified: 2014-09-08 03:08:22 UTC
Created attachment 267467 [details] screenshot showing default window size The account assistant window (which appears when launching Evolution if you have zero accounts configured) is far too wide. I think this is a recent-ish GTK+ change: this window used to be much smaller. Tested Evolution 3.10.3 with GTK+ 3.10.6, and also git master of both Evolution and GTK+
GTK+ regression, though probable dupe. Reassigning.
unless the window is wider than the monitor, I wouldn't count it as a bug. You should set a suitable default size on your assistant window.
Note that this window is "too wide" but actually resizable down to its intended size by the user, so something fishy is going on. It reminds me of the trouble I had in some other situations where gtk would either overcalculate the height or overcalculate the width. In any case, a probable easy workaround is to mark that window as non-resizeable, which would force gtk (I think?) to keep it at the minimum dimensions required to display the contents at any given time. I don't see why users would want to resize this assistant (it does not have multiline textfields afaik).
Created attachment 271136 [details] [review] proposed fix If my proposed workaround above is deemed acceptable, here's a potential fix. It's theoretical, not tested (I don't have a build etc.).
FTR, this is a GTK+ regression introduced in version 3.10.5 by this commit: https://git.gnome.org/browse/gtk+/commit/?id=f18655c641dbe2ca2a28627538898be575667e1a But I suppose we'll have to work around it. Unfortunately making it non-resizable does not fix the regression, so we'll just explicitly set the same defaults that GTK+ removed. Fixed for Evolution 3.11.92 in: https://git.gnome.org/browse/evolution/commit/?id=e678fa918e8c6f414457b4d315e5f69a13455ef1 Still reassigning to GTK+, though. That commit should not have been backported to a stable release branch. I can tell that just from the commit message.
(In reply to comment #2) > unless the window is wider than the monitor, I wouldn't count it as a bug. You > should set a suitable default size on your assistant window. This might be worth reverting in GTK+ due to fallout: see also Bug #729667, Bug #729303, Bug #729304, and Bug #729305. Otherwise, I think this bug should be reassigned back to Evolution.
I actually filed bug #729532 yesterday about the mess that affects not just Evolution (I'd forgot about this bug report here), I suppose it's actually the same problem? Maybe we should mark this bug and all the bugs in comment #6 as "blocked" (dependent) on it?
*** This bug has been marked as a duplicate of bug 729532 ***