After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722918 - Center tab labels
Center tab labels
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-01-24 14:47 UTC by William Jon McCann
Modified: 2016-05-08 08:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Center tab labels (1011 bytes, patch)
2014-01-24 14:47 UTC, William Jon McCann
none Details | Review
Center tab labels (1011 bytes, patch)
2014-01-24 16:15 UTC, William Jon McCann
committed Details | Review
screenshot (17.86 KB, image/png)
2014-02-06 17:58 UTC, William Jon McCann
  Details

Description William Jon McCann 2014-01-24 14:47:20 UTC
Centered tab labels work better when the tabs are set to expand.
Comment 1 William Jon McCann 2014-01-24 14:47:21 UTC
Created attachment 267129 [details] [review]
Center tab labels
Comment 2 Christian Persch 2014-01-24 16:06:44 UTC
-  gtk_misc_set_alignment (GTK_MISC (label), 0.0, 0.5);
+  gtk_widget_set_halign (label, GTK_ALIGN_CENTER);
+  gtk_widget_set_halign (label, GTK_ALIGN_BASELINE);

halign twice?

Also, I disagree about it 'working better', it's quite the opposite actually, IHMO. I'd rather fix the tabbing widget look itself, bug 720323.
Comment 3 William Jon McCann 2014-01-24 16:15:18 UTC
Created attachment 267141 [details] [review]
Center tab labels
Comment 4 William Jon McCann 2014-02-06 17:58:15 UTC
Created attachment 268318 [details]
screenshot

The tabs style has been enhanced to better support reorderable tabs. Is it more to your liking? But really this is an orthogonal issue. Could we please get this patch in so that terminal has tabs that are consistent with our other core applications?
Comment 5 Debarshi Ray 2014-02-13 13:25:48 UTC
Ping? This is not related to the themeing of the tabs.
Comment 6 Debarshi Ray 2014-02-13 17:39:31 UTC
Thanks Behdad!
Comment 7 zhiwei 2015-07-23 00:51:33 UTC
Hi William, Debarshi,

Could make this feature configurable through terminal CSS or theme XML file?

There are some themes that left aligned the window title, but the tab label is centered. It's very discordant, so I hope you can make this configurable to have a better Gnome interface.

Thanks.
Comment 8 Christian Persch 2016-05-08 08:59:37 UTC
AFAIK this is not configurable via CSS.