After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722044 - Remove GTK_STOCK_CANCEL icon from ignore button
Remove GTK_STOCK_CANCEL icon from ignore button
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: housekeeping
unspecified
Other All
: Normal normal
: ---
Assigned To: Richard Hughes
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2014-01-12 15:01 UTC by Baptiste Mille-Mathias
Modified: 2014-01-13 16:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove GTK_STOCK_CANCEL icon from ignore button (1.59 KB, patch)
2014-01-12 15:01 UTC, Baptiste Mille-Mathias 		accepted-commit_now Details | Review
Remove GTK_STOCK_CANCEL icon from ignore button (1.59 KB, patch)
2014-01-13 16:32 UTC, Baptiste Mille-Mathias 		committed Details | Review
Replace deprecated GTK_STOCK items (2.76 KB, patch)
2014-01-13 16:32 UTC, Baptiste Mille-Mathias 		committed Details | Review

Description Baptiste Mille-Mathias 2014-01-12 15:01:21 UTC 
Followup of the bug 720643.
There is no replacement for the icon GTK_STOCK_CANCEL so we drop the icon
from the button.
Comment 1 Baptiste Mille-Mathias 2014-01-12 15:01:23 UTC 
Created attachment 266058 [details] [review]
Remove GTK_STOCK_CANCEL icon from ignore button

There is no replacement for this icon, so better is removing the icon from the
button.
Comment 2 Bastien Nocera 2014-01-13 07:16:17 UTC 
Review of attachment 266058 [details] [review]:

Looks fine.
Comment 3 Baptiste Mille-Mathias 2014-01-13 16:31:59 UTC 
The following fixes have been pushed:
7b82354 Remove GTK_STOCK_CANCEL icon from ignore button
92fc1c2 Replace deprecated GTK_STOCK items
Comment 4 Baptiste Mille-Mathias 2014-01-13 16:32:04 UTC 
Created attachment 266176 [details] [review]
Remove GTK_STOCK_CANCEL icon from ignore button

There is no replacement for this icon, so better is removing the icon from the
button.
Comment 5 Baptiste Mille-Mathias 2014-01-13 16:32:08 UTC 
Created attachment 266177 [details] [review]
Replace deprecated GTK_STOCK items

Starting GTK 3.10 GTK_STOCK items are deprecated in favor of defined labels or
standard icon names.

https://bugzilla.gnome.org/show_bug.cgi?id=720643