After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720643 - Replace deprecated GTK_STOCK items
Replace deprecated GTK_STOCK items
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: housekeeping
unspecified
Other All
: Normal normal
: ---
Assigned To: Richard Hughes
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2013-12-17 21:57 UTC by Baptiste Mille-Mathias
Modified: 2014-02-05 21:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Replace deprecated GTK_STOCK items (3.22 KB, patch)
2013-12-17 21:57 UTC, Baptiste Mille-Mathias 		needs-work Details | Review
Replace deprecated GTK_STOCK items (2.71 KB, patch)
2014-01-12 08:30 UTC, Baptiste Mille-Mathias 		accepted-commit_now Details | Review

Description Baptiste Mille-Mathias 2013-12-17 21:57:05 UTC 
Starting GTK 3.10 GTK_STOCK items are deprecated in favor of defined labels or
standard icon names.
Comment 1 Baptiste Mille-Mathias 2013-12-17 21:57:06 UTC 
Created attachment 264451 [details] [review]
Replace deprecated GTK_STOCK items

Starting GTK 3.10 GTK_STOCK items are deprecated in favor of defined labels or
standard icon names.
Comment 2 Bastien Nocera 2014-01-10 14:10:48 UTC 
Review of attachment 264451 [details] [review]:

Rest looks fine.

::: plugins/housekeeping/gsd-ldsm-dialog.c
@@ -449,3 @@
                                                _("Ignore"), 
                                                GTK_RESPONSE_CANCEL);
-        ignore_image = gtk_image_new_from_stock (GTK_STOCK_CANCEL, GTK_ICON_SIZE_BUTTON);

Why don't we keep the icon? It's probably not needed anymore, but it should be removed in a separate patch.
Comment 3 Baptiste Mille-Mathias 2014-01-12 08:30:41 UTC 
Created attachment 266052 [details] [review]
Replace deprecated GTK_STOCK items

Starting GTK 3.10 GTK_STOCK items are deprecated in favor of defined labels or
standard icon names.
Comment 4 Baptiste Mille-Mathias 2014-01-12 15:02:29 UTC 
Hi,

the deletion of the icon is done in the bug 722044
Comment 5 Bastien Nocera 2014-01-13 07:14:58 UTC 
Review of attachment 266052 [details] [review]:

Rest looks fine.

::: plugins/housekeeping/gsd-ldsm-dialog.c
@@ +451,3 @@
         ignore_image = gtk_image_new_from_stock (GTK_STOCK_CANCEL, GTK_ICON_SIZE_BUTTON);
         gtk_button_set_image (GTK_BUTTON (button_ignore), ignore_image);
+

Whitespace change.
Comment 6 Baptiste Mille-Mathias 2014-02-05 21:17:06 UTC 
commit 92fc1c2f605561126e37dc9a69459d5ac66c1e90
Author: Baptiste Mille-Mathias <baptiste.millemathias@gmail.com>
Date:   Tue Dec 17 22:54:24 2013 +0100

    Replace deprecated GTK_STOCK items
    
    Starting GTK 3.10 GTK_STOCK items are deprecated in favor of defined labels or standard icon names.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=720643