Now, if in the string to search has uppercase, there is a case sensitive search.
If in the string has not uppercase, there is a case insensitive search.

I think or to keep the current, or to add check button „Match Case”.

Yosef is right. We deliberately made it this way in the 2012 hackfest IIRC.

Hm... that kind of makes sense, but other GNOME apps do not behave this way. This seems like a discoverability issue.

Has this been settled?

I would like to work on it (thinking that a "Match Case" button would be good to have)

It has not been settled. I'm quite sure I hate the current behavior; either searches should always be case-insensitive, or we need some checkbox for this, and I'd rather not add a checkbox to the nice clean search bar tbh.

Could you please ask aday in #gnome-design for his opinion?

I'd probably just do case insensitive all the way - it is less error-prone. I can think of cases where you might want to toggle the sensitivity in a text or code editor; less so in a web browser.

Created attachment 321993 [details] [review]
Always do case-insensitive search

Okay then.

Let me know what you think of this.

Review of attachment 321993 [details] [review]:

Good with one change

::: embed/ephy-find-toolbar.c
@@ +178,3 @@
                 return;
 
+        options |= WEBKIT_FIND_OPTIONS_CASE_INSENSITIVE;

Instead, just declare it as:

WebKitFindOptions options = WEBKIT_FIND_OPTIONS_CASE_INSENSITIVE;

Created attachment 322155 [details] [review]
Always do case-insensitive search

(In reply to Michael Catanzaro from comment #8)
> ::: embed/ephy-find-toolbar.c
> @@ +178,3 @@
>                  return;
>  
> +        options |= WEBKIT_FIND_OPTIONS_CASE_INSENSITIVE;
> 
> Instead, just declare it as:
> 
> WebKitFindOptions options = WEBKIT_FIND_OPTIONS_CASE_INSENSITIVE;

Sure.

Review of attachment 322155 [details] [review]:

Do you have a GNOME account yet? Probably time to apply for one. See https://wiki.gnome.org/AccountsTeam/NewAccounts

Mention your contributions to Nibbles and that I think it'd be helpful for you to have commit access.

Attachment 322155 [details] pushed as fe3b8ab - Always do case-insensitive search