GNOME Bugzilla – Bug 720994
Super+S keyboard shortcut is assigned to two entries
Last modified: 2017-01-30 10:08:20 UTC
Fedora 20. Settings -> Keyboard -> Shortcuts -> System. Super+S is assigned to two entries (Show overview and Show applications overview). I've switched one of the two to Super+D for testing and both seem to do the same thing regardless from which screen you perform the keyboard shortcut.
"Panel main menu" was added in: commit 8808a8fdba48fb55de84de3e98e081b38f2fd92d Author: Matthias Clasen <mclasen@redhat.com> Date: Wed Apr 17 18:59:01 2013 -0400 Add an alternative shortcut for 'go to overview' We have Alt-F1 as a shortcut for opening the overview, but for the reasons discussed in https://bugzilla.gnome.org/show_bug.cgi?id=685974 it is a good idea to have an alternative that uses the Super modifier, and goes well with Super-A. This patch adds Super-S. The one in gnome-settings-daemon in: commit f20df9907933d24519a5e69d565cf25715349fda Author: Alejandro Piñeiro <apinheiro@igalia.com> Date: Tue Aug 13 20:41:49 2013 +0200 Adding shortcut for toggle screen reader https://bugzilla.gnome.org/show_bug.cgi?id=705929 I'll revert the latter and reopen bug 705929.
Created attachment 264849 [details] Screenshot showing two items (neither of which are screen reader) bound to Super+S As I commented on the bug you reopened, the screen reader was not bound to Super+S; it was bound to Alt+Super+S.
Yep, "Show overview" and "Show the activities overview", and the two commands seem to do the same thing. I knew I'd commit a mistake in the bug description. :P
(In reply to comment #1) > The one in gnome-settings-daemon in: > commit f20df9907933d24519a5e69d565cf25715349fda > Author: Alejandro Piñeiro <apinheiro@igalia.com> > Date: Tue Aug 13 20:41:49 2013 +0200 > > Adding shortcut for toggle screen reader > > https://bugzilla.gnome.org/show_bug.cgi?id=705929 > > I'll revert the latter and reopen bug 705929. But as said on bug 705929, the change you reverted just removed a binding to Super+Alt+S, not to Super+S as the bug description says. Reopening the bug in order to clarify this bug.
BTW what's the point of Super+S? It can't even be used to toggle between apps (Super+A) and windows (Super+S). "Super" alone does exactly the same thing as Super+S.
(In reply to comment #0) > Fedora 20. > > Settings -> Keyboard -> Shortcuts -> System. > > Super+S is assigned to two entries (Show overview and Show applications > overview). That's: toggle-overview in org.gnome.shell.keybindings ("Show the activities overview") and toggle-application-view in toggle-application-view ("Show the overview") > I've switched one of the two to Super+D for testing and both seem to do the > same thing regardless from which screen you perform the keyboard shortcut.
One of those is in gsettings-desktop-schemas, the other in gnome-shell.
'toggle-overview' (<super>s) was introduced as alternative to the traditional 'panel-main-menu' (<alt>f1) in bug 698251, as the latter is overwritten in classic mode to open the application menu instead of the overview. That's why there's two shortcuts for the same thing (at least in a normal session). The <super>s alias to <alt>f1 introduced in commit 8808a8fdba48 is broken however ...
(In reply to Florian Müllner from comment #8) > 'toggle-overview' (<super>s) was introduced as alternative to the > traditional 'panel-main-menu' (<alt>f1) in bug 698251, as the latter is > overwritten in classic mode to open the application menu instead of the > overview. That's why there's two shortcuts for the same thing (at least in a > normal session). The <super>s alias to <alt>f1 introduced in commit > 8808a8fdba48 is broken however ... I don't understand how it's broken, or how we should proceed towards fixing this.
The same shortcut - <super>s - is used for two different actions, which doesn't work - after registering the first shortcut, grabbing the second one will fail. That is, only one of the 'panel-main-menu' and 'toggle-overview' action will actually work(*). This doesn't matter when the apps-menu extension is not used, because the actions do the same thing in that case, but in the case where the newly added action is actually useful, <super>s will only work as expected when 'toggle-overview' is the "winning" action. I think the correct fix here is to revert commit 8808a8fdba48, so we have <alt>f1 for 'panel-main-menu' and <super>s for 'toggle-overview' - that way, <super>s will always toggle the overview, and <alt>f1 will either act as an alternative or toggle the apps menu. (*) It happens to be 'panel-main-menu' because it is initialized by mutter before handling control over to gnome-shell's javascript, but I don't want any code relying on a particular order, so let's say it is random.
Created attachment 344518 [details] [review] Revert "Add an alternative shortcut for 'go to overview'" This reverts commit 8808a8fdba48fb55de84de3e98e081b38f2fd92d. The same shortcut - <super>s - is used for two different actions, which doesn't work - after registering the first shortcut, grabbing the second one will fail. That is, only one of the 'panel-main-menu' and 'toggle-overview' action will actually work. This doesn't matter when the apps-menu extension is not used, because the actions do the same thing in that case, but in the case where the newly added action is actually useful, <super>s will only work as expected when 'toggle-overview' is the "winning" action. The fix here is to revert commit 8808a8fdba48, so we have <alt>f1 for 'panel-main-menu' and <super>s for 'toggle-overview' - that way, <super>s will always toggle the overview, and <alt>f1 will either act as an alternative or toggle the apps menu. With help from Florian Müllner <florian.muellner@gmail.com> Conflicts: schemas/org.gnome.desktop.wm.keybindings.gschema.xml.in
Pushed to master and gnome-3-22 Attachment 344518 [details] pushed as dd31e69 - Revert "Add an alternative shortcut for 'go to overview'"