After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705929 - Needed shortcut for toggle screen reader
Needed shortcut for toggle screen reader
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: media-keys
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
3.10
Depends on:
Blocks:
 
 
Reported: 2013-08-13 18:41 UTC by Alejandro Piñeiro Iglesias (IRC: infapi00)
Modified: 2014-01-28 14:58 UTC
See Also:
GNOME target: 3.10
GNOME version: ---


Attachments
Super+Alt+s shortcut activates/deactivates screen reader (1.09 KB, patch)
2013-08-13 18:45 UTC, Alejandro Piñeiro Iglesias (IRC: infapi00)
needs-work Details | Review

Description Alejandro Piñeiro Iglesias (IRC: infapi00) 2013-08-13 18:41:33 UTC
Right now there isn't a default shortcut for toggling screen reader, something that was always desired. For example, one of the commong things of all the custom accessibility related distros was define a default shortcut for that.

Right now is event more important as the accessibility icon is not always available at the top panel (although in any case, without screen reader, a screen reader user had a bad time searching for it).

I talked with Jakub during GUADEC and he didn't have any problem on adding one.
Comment 1 Alejandro Piñeiro Iglesias (IRC: infapi00) 2013-08-13 18:45:26 UTC
Created attachment 251541 [details] [review]
Super+Alt+s shortcut activates/deactivates screen reader

Taking into account that the magnifier is already using the form "Super+Alt+<something>" for activating, zooming-in, zooming-out, "Super+Alt+s" seems the straightforward one for the Screen reader.
Comment 2 Matthias Clasen 2013-08-17 15:31:15 UTC
Review of attachment 251541 [details] [review]:

looks fine
Comment 3 Bastien Nocera 2013-08-19 03:05:13 UTC
Was missing a prefix to the commit subject, and an explanation why this shortcut was chosen in the commit message.
Comment 4 Bastien Nocera 2013-12-24 16:42:41 UTC
Reopening, as I've reverted the commit.

Super+S is already taken:
https://bugzilla.gnome.org/show_bug.cgi?id=720994
Comment 5 Joanmarie Diggs (IRC: joanie) 2013-12-24 16:52:58 UTC
Bastien, I'm a bit confused. On my F20 system, Super+S puts me in the overview and Super+Alt+S puts me in the screen reader.
Comment 6 Alejandro Piñeiro Iglesias (IRC: infapi00) 2014-01-07 11:43:36 UTC
(In reply to comment #4)
> Reopening, as I've reverted the commit.
> 
> Super+S is already taken:

Ok, but ...

(In reply to comment #1)
> Created an attachment (id=251541) [details] [review]
> Super+Alt+s shortcut activates/deactivates screen reader

Super+Alt+S is the one used for the screen reader. The rationale (not explained on the commit, sorry for that) is because Super+Alt+<something> was already used on the magnifier:

> Taking into account that the magnifier is already using the form
> "Super+Alt+<something>" for activating, zooming-in, zooming-out, "Super+Alt+s"
> seems the straightforward one for the Screen reader.
Comment 7 William Jon McCann 2014-01-07 12:07:33 UTC
https://wiki.gnome.org/Design/OS/KeyboardShortcuts
Comment 8 Bastien Nocera 2014-01-28 14:58:48 UTC
commit cb349b986e0434b1dcc7919ea8b99a022646ba25
Author: Bastien Nocera <hadess@hadess.net>
Date:   Tue Jan 28 15:50:29 2014 +0100

    Revert "Revert "Adding shortcut for toggle screen reader""
    
    This reverts commit 11c0be5410caf47adaa968fb852f4a1f62210bde.
    
    Wrong keybinding.

Fixed in gnome-3-10 and master.