After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720652 - Chooser dialog is too wide
Chooser dialog is too wide
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Background
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Debarshi Ray
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-12-18 03:52 UTC by Matthias Clasen
Modified: 2014-01-08 15:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
background: The chooser should have exactly 3 columns (1.22 KB, patch)
2013-12-19 17:00 UTC, Debarshi Ray
none Details | Review
background: The chooser should have exactly 3 columns (1.22 KB, patch)
2014-01-08 14:46 UTC, Debarshi Ray
committed Details | Review

Description Matthias Clasen 2013-12-18 03:52:15 UTC
We should restrict the icon views to 3 columns
Comment 1 Debarshi Ray 2013-12-18 11:48:19 UTC
Assuming that you are seeing this in 3.11.x, my casual guess is that this is related to bug 720188
Comment 2 Matthias Clasen 2013-12-18 22:09:25 UTC
sure, same thing
Comment 3 Debarshi Ray 2013-12-19 16:59:55 UTC
After playing with ./panels/background/test-chooser-dialog I found that the icon view becomes wider when data is inserted into the list store. This might be due to a GTK+ change within the 3.11.2 and 3.11.3 timeframe, but the way we were restricting the icon view to have 3 columns looks wrong to me.

We were (arbitrarily?) setting the size request on the big grid so that it is just wide enough to have 3 columns. See:

commit a4cf2839378c09e756c9c1ebe07adb036f7d3f26
Author: Bastien Nocera <hadess@hadess.net>
Date:   Wed Nov 14 23:06:07 2012 +0100

    background: Fix not having 3 columns in high contrast
    
    Increase the width slightly to 860 from 850.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=683499

commit 79ec684fa4912a1e5bff17ce11b036cef4a298aa
Author: William Jon McCann <jmccann@redhat.com>
Date:   Tue May 22 11:34:20 2012 -0400

    background: New background panel design
    
    Implement a new design for the wallpaper selection.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=676539

Using gtk_icon_view_set_columns looks more correct to me, and it fixes this problem.
Comment 4 Debarshi Ray 2013-12-19 17:00:36 UTC
Created attachment 264555 [details] [review]
background: The chooser should have exactly 3 columns
Comment 5 Debarshi Ray 2014-01-08 14:46:25 UTC
Created attachment 265709 [details] [review]
background: The chooser should have exactly 3 columns
Comment 6 Bastien Nocera 2014-01-08 15:37:20 UTC
Review of attachment 265709 [details] [review]:

Sure, please commit to gnome-3-10 and master.
Comment 7 Debarshi Ray 2014-01-08 15:50:25 UTC
Comment on attachment 265709 [details] [review]
background: The chooser should have exactly 3 columns

Committed to both master and gnome-3-10. Thanks for the review.