GNOME Bugzilla – Bug 676539
improve background selection design
Last modified: 2012-08-22 13:38:07 UTC
Created attachment 214631 [details] mockup There are a few things that I would like to improve in the background settings. * Not use a monitor metaphor * Show the selected wallpaper in larger size * Allow the design to support separate selection of lock and background images * Allow the selection mode to show large size images of the correct aspect ratio instead of just tiny squares * Use content selection pattern instead of file selection for images
Created attachment 214632 [details] screenshot so far Need to add in the top bar etc.
Wonder if we could add a way for the shell to tell us exactly what the top bar looks like...
There is a start in the wip/background-content branch.
Also see https://live.gnome.org/GnomeOS/Design/Whiteboards/ContentSelection
Created attachment 220863 [details] [review] New background panel design
Still to do: * If we want to keep the color backgrounds we should probably just come up with a few good ones instead of relying on the color selector. Jakub what do you think? * The emblems are rendered very small * The items from the wallpapers view are fuzzy while the ones from Pictures are not
I agree we should keep this a selector. So no color mixing, no RGBA image+color background blending, gradient direction. All of these are implementation details of something that's a wallpaper. As for the flat colors, I prepared this set: #828b98 #86af8f #d59659 #727e6f #57667c #6aa978 #f57900 #67915c #edd400 #ad7fa8 #770000 #8f5902 Most of these are pale, not saturated. People picking flat color as opposed to an image are likely to be interested in something that's not attention grabbing. I'll throw in some gradients next.
Created attachment 220869 [details] color sample chart
Trying out the gradients in 3.4, we suffer from extreme color banding there. Unless we have some sort of dithering (like GIMP does), I would rather not have any gradients.
Created attachment 220906 [details] [review] New background panel design
Created attachment 220907 [details] [review] New background panel design Select item on activation.
Created attachment 221030 [details] [review] Remove sheen overlay The metaphor was valid when we used a monitor to display the preview but now it doesn't work. There is no glass to reflect light. It distracts from the preview and may look like a defect.
Created attachment 221031 [details] [review] background: use a texture on the color wallpapers
Created attachment 221335 [details] [review] Update the preview when the settings change
Created attachment 221336 [details] [review] Update the preview when the settings change Oops, remove debug line
Review of attachment 220907 [details] [review]: ::: panels/background/bg-colors-source.c @@ +56,3 @@ + { G_DESKTOP_BACKGROUND_SHADING_SOLID, -1, "#d59659", "#d59659" }, + { G_DESKTOP_BACKGROUND_SHADING_SOLID, -1, "#86af8f", "#86af8f" }, + { G_DESKTOP_BACKGROUND_SHADING_SOLID, -1, "#828b98", "#828b98" }, Will we want pcolor != scolor at some point? If not, why not simplify this? @@ +85,3 @@ store = bg_source_get_liststore (BG_SOURCE (self)); + thumb_factory = gnome_desktop_thumbnail_factory_new (GNOME_DESKTOP_THUMBNAIL_SIZE_LARGE); Could the size changes be made separately? ::: panels/background/bg-source.h @@ +28,3 @@ +#define THUMBNAIL_WIDTH 256 +#define THUMBNAIL_HEIGHT 153 Make the height a calculation based on width, rather than a magic number. The compiler will take care of optimising it. ::: panels/background/cc-background-chooser-dialog.c @@ +184,3 @@ + gtk_window_set_modal (GTK_WINDOW (chooser), TRUE); + gtk_window_set_resizable (GTK_WINDOW (chooser), FALSE); + /* translators: This is the title of the "Add Account" dialogue. It's not. ::: panels/background/cc-background-panel.c @@ -31,3 @@ #include "bg-colors-source.h" -#ifdef HAVE_LIBSOCIALWEB If we're removing support for using the flickr bg source, then shitloads of code needs to get removed. Leave it in for now and we can remove all that code at once?
Review of attachment 221030 [details] [review]: Looks good.
Review of attachment 221031 [details] [review]: Looks good.
Review of attachment 221336 [details] [review]: Looks good.
As usual, the code's close to perfect ;) Couple of comments on the patches and code itself before you commit: - prefix all your commit subjects with "background: ", it makes it easier to find the changes afterwards - the "changes through time" icon is too small in the previews - the text in the "source" changes isn't centered within each button Would be great if you could try to split up the changes that can be applied separately (like the thumbnail size, or the flickr backend removal).
Created attachment 221672 [details] [review] background: New background panel design Implement a new design for the wallpaper selection.
Created attachment 221673 [details] [review] background: Remove sheen overlay The metaphor was valid when we used a monitor to display the preview but now it doesn't work. There is no glass to reflect light. It distracts from the preview and may look like a defect.
Created attachment 221674 [details] [review] background: Update the preview when the settings change They may be change from outside (eg. Nautilus).
(In reply to comment #20) > - the "changes through time" icon is too small in the previews Indeed. I need to look into this. I think there may be a gtk bug. We're not doing anything special here as far as I can see. Bug 682123 > - the text in the "source" changes isn't centered within each button Bug 681617 - It is marked as a blocker for this bug. We need it but don't want to wait for it.
*** Bug 668899 has been marked as a duplicate of this bug. ***
*** Bug 675460 has been marked as a duplicate of this bug. ***