After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720417 - meta_window_move_resize_internal: handle border size changes
meta_window_move_resize_internal: handle border size changes
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
: 720469 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-12-13 18:59 UTC by Owen Taylor
Modified: 2013-12-18 14:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
meta_window_move_resize_internal: handle border size changes (1.12 KB, patch)
2013-12-13 18:59 UTC, Owen Taylor 		committed Details | Review

Description Owen Taylor 2013-12-13 18:59:49 UTC 
Initial placement during meta_window_constrain() can result in changes
to the borders, so we need to recompute our border sizes after
constraining. This fixes incorrect window borders on
initially maximized windows.
Comment 1 Owen Taylor 2013-12-13 18:59:51 UTC 
Created attachment 264168 [details] [review]
meta_window_move_resize_internal: handle border size changes
Comment 2 Owen Taylor 2013-12-13 19:01:21 UTC 
Yosef - can you check if this fixes the residual problems you were seeing?
Comment 3 Owen Taylor 2013-12-15 01:24:44 UTC 
*** Bug 720469 has been marked as a duplicate of this bug. ***
Comment 4 Yosef Or Boczko 2013-12-17 19:23:02 UTC 
Yes, the patch realy fixes the residual problems.

Now I see other something strange: when I switch
between maximize to unmaximize, the size of the close
button change.
But I not thing it realte to this bug.
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-12-17 19:28:23 UTC 
Review of attachment 264168 [details] [review]:

If it fixes Yosef's problem, looks good.

::: src/core/window.c
@@ +4988,3 @@
+   */
+  meta_frame_calc_borders (window->frame,
+                           &borders);

This can be on one line.
Comment 6 Owen Taylor 2013-12-18 14:27:07 UTC 
Attachment 264168 [details] pushed as b7e62d3 - meta_window_move_resize_internal: handle border size changes