GNOME Bugzilla – Bug 720108
Build error: bt-widget.c:33:30: fatal error: bluetooth-plugin.h: No such file or directory
Last modified: 2014-02-17 20:35:53 UTC
This is in a fresh jhbuild building meta-gnome-core with gnome-world-3.12 The plugin support was removed in gnome-bluetooth, see https://git.gnome.org/browse/gnome-bluetooth/commit/?id=074dbf2b7f5a7d110dafb9e5280a4d44011428b3 libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -DDATADIR=\"/home/gnomedev/jhbuild/install/share\" -DICONDIR=\"\" -DLOCALEDIR=\"/home/gnomedev/jhbuild/install/share/locale\" -I../.. -I../../src/marshallers -I../../src/utils -I../../src/libnm-gtk -pthread -I/home/gnomedev/jhbuild/install/include/gnome-bluetooth -I/home/gnomedev/jhbuild/install/include/gtk-3.0 -I/home/gnomedev/jhbuild/install/include/at-spi2-atk/2.0 -I/home/gnomedev/jhbuild/install/include/gtk-3.0 -I/home/gnomedev/jhbuild/install/include/gio-unix-2.0/ -I/home/gnomedev/jhbuild/install/include/pango-1.0 -I/home/gnomedev/jhbuild/install/include/harfbuzz -I/home/gnomedev/jhbuild/install/include/pango-1.0 -I/home/gnomedev/jhbuild/install/include/atk-1.0 -I/usr/include/freetype2 -I/home/gnomedev/jhbuild/install/include/gdk-pixbuf-2.0 -I/home/gnomedev/jhbuild/install/include/libnm-glib -I/home/gnomedev/jhbuild/install/include/NetworkManager -I/home/gnomedev/jhbuild/install/include/glib-2.0 -I/home/gnomedev/jhbuild/install//lib64/glib-2.0/include -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libdrm -I/usr/include/libpng16 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -DGCONF_DISABLE_DEPRECATED -DGCONF_DISABLE_SINGLE_INCLUDES -DBONOBO_DISABLE_DEPRECATED -DBONOBO_DISABLE_SINGLE_INCLUDES -DBONOBO_UI_DISABLE_DEPRECATED -DBONOBO_UI_DISABLE_SINGLE_INCLUDES -DGNOME_DISABLE_DEPRECATED -DGNOME_DISABLE_SINGLE_INCLUDES -DLIBGLADE_DISABLE_DEPRECATED -DLIBGLADE_DISABLE_SINGLE_INCLUDES -DGNOME_VFS_DISABLE_DEPRECATED -DGNOME_VFS_DISABLE_SINGLE_INCLUDES -DWNCK_DISABLE_DEPRECATED -DWNCK_DISABLE_SINGLE_INCLUDES -DLIBSOUP_DISABLE_DEPRECATED -DLIBSOUP_DISABLE_SINGLE_INCLUDES -pthread -I/home/gnomedev/jhbuild/install/include/libmm-glib -I/home/gnomedev/jhbuild/install/include/glib-2.0 -I/home/gnomedev/jhbuild/install//lib64/glib-2.0/include -I/home/gnomedev/jhbuild/install/include/ModemManager -g -O2 -MT libnma_la-bt-widget.lo -MD -MP -MF .deps/libnma_la-bt-widget.Tpo -c bt-widget.c -fPIC -DPIC -o .libs/libnma_la-bt-widget.o bt-widget.c:33:30: fatal error: bluetooth-plugin.h: No such file or directory #include <bluetooth-plugin.h> ^ compilation terminated.
*** Bug 720343 has been marked as a duplicate of this bug. ***
Created attachment 264820 [details] [review] build: don't try to build bluetooth widget with newer gnome-bluetooth Since the plugin API no longer exists
Review of attachment 264820 [details] [review]: ::: configure.ac @@ +150,3 @@ + AC_MSG_CHECKING(whether to build gnome-bluetooth widget) + case `$PKG_CONFIG --modversion gnome-bluetooth-1.0` in + 2.*|3.?.*) I'm no reference by far.. but this looks entirely weird to me Why not use something like if `$PKG_CONFIG --max-version 3.11.0 gnome-bluetooth-1.0`; then build_gbt_widget=yes else build_gbt_widget=no fi Sounds less error prone and actually allows the widget plugin still to be built with 3.10.x, where the API was still in place AFAIR.
Actually, looking at configure, this is even more overcoplicated than I'd think is needed. HAVE_GBT is only needed inside the gnome-bluetooth directory. So havine a BUILD_GBT_WIDGET set to false won't use that directory at all anymore; so the two could as well be merged. (In fact I don't think conditionally entering directories is a good thing, as this can cause issus with make dist) The check for max-version could probably just be added into the PKG_CHECK_MODULES(GNOME_BLUETOOTH, call, using gnome-bluetooth-1.0 >= 2.27.6 gnome-bluetooth-1.0 < 3.11.0
(In reply to comment #4) > (In fact I don't think conditionally entering directories is a good thing, as > this can cause issus with make dist) No, automake explicitly deals with that. > The check for max-version could probably just be added into the > PKG_CHECK_MODULES(GNOME_BLUETOOTH, > > call, using > gnome-bluetooth-1.0 >= 2.27.6 > gnome-bluetooth-1.0 < 3.11.0 ah... didn't realize you could do that
Created attachment 265139 [details] [review] build: don't try to build bluetooth widget with newer gnome-bluetooth Since the plugin API no longer exists. (Also, fix the configure output to not print two "checking for" messages.)
*** Bug 724355 has been marked as a duplicate of this bug. ***
fixed in master Attachment 265139 [details] pushed as 0a3ec42 - build: don't try to build bluetooth widget with newer gnome-bluetooth