After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 72008 - The items on the Applications and Actions menus should have accelerator keys (but not the menu titles themselves)
The items on the Applications and Actions menus should have accelerator keys ...
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: panel
unspecified
Other All
: High enhancement
: ---
Assigned To: Panel Maintainers
Panel Maintainers
AP2
: 93550 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2002-02-20 11:45 UTC by Calum Benson
Modified: 2015-03-24 13:00 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
Proposed patch to provide the accelerator keys (5.73 KB, patch)
2003-07-05 11:26 UTC, Muktha
none Details | Review

Description Calum Benson 2002-02-20 11:45:15 UTC
Summary says it all... the items on the Applications and Actions menus
should have accelerator keys. (Didn't they used to have?)  Just because
there's currently no way to get to those menus via the keyboard doesn't
mean there won't be soon :)
Comment 1 Luis Villa 2002-02-20 21:02:57 UTC
This is a fairly major keynav issue, sounds like.
Comment 2 Gediminas Paulauskas 2002-02-23 00:43:07 UTC
moving gnome-panel-2 specific bugs to gnome-panel product
Comment 3 Calum Benson 2002-07-17 10:46:57 UTC
One issue here is that the items themselves can't necessarily have
access keys (as the menus are mostly generated dynamically, so it
would be hard to avoid clashes).  However, Windoze Start menu has the
same problem, and it solves it by letting you activate a menu item by
pressing its first letter, or by cycling focus between items starting
with the same letter.

(Although it seems to me that if we're going to do this, we might as
well just make it explicit and put the underscore on the first letter
of each menu item).
Comment 4 Mark McLoughlin 2002-08-11 11:33:11 UTC
Yeah, the first letter thing sounds like a good idea. Its an
enhancement request, though. Marking it as such.
Comment 5 Mark McLoughlin 2002-09-23 04:13:05 UTC
*** Bug 93550 has been marked as a duplicate of this bug. ***
Comment 6 Kjartan Maraas 2002-10-28 18:43:09 UTC
If this is a major keynav issue, how come it's marked as enhancement?
Comment 7 Calum Benson 2002-11-20 19:15:33 UTC
Don't ask me :)
Comment 8 Luis Villa 2002-12-04 19:52:47 UTC
Because it sounded like one to me and Mark overruled me :) 
Comment 9 Calum Benson 2003-04-03 14:44:13 UTC
Updating status_whiteboard field to reflect A11Y team's assessment 
of accessibility impact.
Comment 10 padraig.obriain 2003-06-27 07:51:28 UTC
Based on rcent mails on the gnome-accessibilty-list I think that the
menu popped up using Alt+F1 should also have accelerators.
Comment 11 Calum Benson 2003-06-30 14:37:04 UTC
This one's being lying around a long time and it's now beginning to
attract comments on gnome-accessibility-list :)  Upgrading to AP2
accordingly...
Comment 12 Brian Cameron 2003-07-02 10:16:15 UTC
This a11y stopper bug would be nice to fix before the July 7th
UI freeze deadline.
Comment 13 Muktha 2003-07-05 11:26:39 UTC
Created attachment 18051 [details] [review]
Proposed patch to provide the accelerator keys
Comment 14 Mark McLoughlin 2003-07-07 10:41:47 UTC
Thanks Muktha :-)

Okay, I've just committed this:

2003-07-07  Mark McLoughlin  <mark@skynet.ie>
                                                                     
                                                       
        Add mnemonics to the Applications, Actions and "Add to Panel"
        menus, but make the ones in Applications invisible. Based
        on a patch from Muktha in bug #72008.
                                                                     
                                                       
        * menu.c:
        (setup_mnemonic), (setup_invisible_mnemonic): implement
        setting a mnemonic for a menu item without actually
        underlining the appropriate character.
        (create_menuitem): set an invisible mnemonic.
        (applet_menu_append), (applet_menu_append_category),
        (make_add_submenu): use visible mnemonics here.
                                                                     
                                                       
        * menu-util.c: (stock_menu_item_new): allow mnemonics.
                                                                     
                                                       
        * panel-menu-bar.c: (panel_menu_bar_append_actions_menu):
        add mnemonics to the Actions menu.
                                                                     
                                                       
        * panel-recent.c: (panel_recent_append_documents_menu):
        add mnemonic.
                                                                     
                                                       




The big difference between this and Muktha's patch is that the
mnemonics for the Applications menu are invisible. Decided to do this
after talking to Calum about it ...