After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 713999 - Suggest appropriate file extension when saving an image without one
Suggest appropriate file extension when saving an image without one
Status: RESOLVED FIXED
Product: geary
Classification: Other
Component: attachments
unspecified
Other All
: Normal normal
: 0.12.0
Assigned To: Michael Gratton
Geary Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-09-12 02:11 UTC by Jim Nelson
Modified: 2017-02-15 22:26 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Charles Lindsay 2013-11-21 20:23:55 UTC


---- Reported by jim@yorba.org 2013-09-11 19:11:00 -0700 ----

Original Redmine bug id: 7477
Original URL: http://redmine.yorba.org/issues/7477
Searchable id: yorba-bug-7477
Original author: Jim Nelson
Original description:

When saving an image, the filename is obtained with GMime.Part.get_filename(),
which first looks for a "filename" parameter in `Content-Disposition`, then a
"name" parameter in `Content-Type`.

If no filename is found there and the image has been injected into the
document because of its `Content-Disposition`, then no filename will be
suggested to the user. If no filename is found and the image is displayed
because it's an IMG tag in an HTML document using a `cid:` URI, then the IMG's
ALT attribute is the suggested filename.

In many of these cases, it's possible that a filename with no extension will
be suggested to the user when saving the image. In that case, Geary should
deduce an appropriate extension from the image's MIME type and append it to
the filename.

Related issues:
related to geary - 7475: Save inline image sent via a MIME Content-ID (Fixed)
related to geary - Feature #5836: Need an option for saving embedded / inline
images displa... (Fixed)



--- Bug imported by chaz@yorba.org 2013-11-21 20:24 UTC  ---

This bug was previously known as _bug_ 7477 at http://redmine.yorba.org/show_bug.cgi?id=7477

Unknown version " in product geary. 
   Setting version to "!unspecified".
Unknown milestone "unknown in product geary. 
   Setting to default milestone for this product, "---".
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
Resolution set on an open status.
   Dropping resolution 

Comment 1 Michael Gratton 2017-02-07 14:15:23 UTC
*** Bug 778026 has been marked as a duplicate of this bug. ***
Comment 2 Michael Gratton 2017-02-07 14:16:02 UTC
I have some WIP on this stashed somewhere.
Comment 3 Michael Gratton 2017-02-15 22:26:09 UTC
Fixed on master by commit 2a7fca9.