GNOME Bugzilla – Bug 713056
Inline images are not added to reply or forwarded emails in composer
Last modified: 2021-07-05 13:27:29 UTC
---- Reported by jim@yorba.org 2013-06-26 11:42:00 -0700 ---- Original Redmine bug id: 7163 Original URL: http://redmine.yorba.org/issues/7163 Searchable id: yorba-bug-7163 Original author: Jim Nelson Original description: If a message contains inline images, they're not included in the composer when the user replies to or forwards a message. Related issues: related to geary - 6942: Inline image from not displayed when surrounded by text/p... (Fixed) related to geary - 5748: Non-image inline attachments not shown in client (Fixed) blocked by geary - Feature #5301: Insert images into mail composer (Open) ---- Additional Comments From geary-maint@gnome.bugs 2013-09-04 12:54:00 -0700 ---- ### History #### #1 Updated by Jim Nelson 3 months ago * **Target version** changed from _0.4.0_ to _0.5.0_ --- Bug imported by chaz@yorba.org 2013-11-21 20:19 UTC --- This bug was previously known as _bug_ 7163 at http://redmine.yorba.org/show_bug.cgi?id=7163 Unknown milestone "unknown in product geary. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one. Resolution set on an open status. Dropping resolution
This was fixed on master by efb7ecb as part of Bug 712995.
Mike, I tried to verify it and it's not fixed for me. This happens on 0.11.0+431~ga88151a - if I reply there's no inline image in the composer - if I forward, the image is attached but does not appear inline I tested this on an email sent by an iPhone. This is the beginning of the message source: --Apple-Mail-22DE3DFB-FB76-4C25-AE85-7CE78CAED421 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit --Apple-Mail-22DE3DFB-FB76-4C25-AE85-7CE78CAED421 Content-Type: image/jpeg; name=IMG_1352.JPG; x-apple-part-url=6031FA2A-65A9-4D62-AF82-9F493E6B1424 Content-Disposition: inline; filename=IMG_1352.JPG Content-Transfer-Encoding: base64
But it works fine with an email - written in Geary - containing an inline image. So the problem is definitely with the iPhone/Apple emails.
Hey Federico, thanks for the info. Just to confirm, is the message ContentType for these messages multipart/related?
This is what I see in the header: Content-Type: multipart/mixed; boundary=Apple-Mail-22DE3DFB-FB76-4C25-AE85-7CE78CAED421
It happened again with a newsletter sent by Mailchimps. In the header I see: Content-Type: multipart/alternative; boundary="_----------=_MCPart_1015869517" and then: This is a multi-part message in MIME format
Federico, is it possible to send me (a redacted version of) a mail that has this problem? I'm trying to investigate this bug, but I can't seem to reproduce it
Niels, I've sent privately to you the mailchimp email. I've checked again the emails sent from iPhone and all seem to work fine.
Hey you two, I just tried replying an (admittedly older) Apple Mail message and it seemed to work, but only if rich text is enabled - nothing was attached if the reply was plain text. Does that sound about right? This behaviour kind of makes sense, since you can't embed images in plain text images, but perhaps we be adding them as attachments in that case since they get displayed in the reply/forward body, but then silently lost. It would be pretty trivial to simply attach any inline parts Geary.RFC822.Message.from_composed_email() to make that happen, but then people wouldn't be able to remove any images they don't want to be sent, which is pretty bad. The correct fix when in plain text mode is probably to at least expose any inline parts as attachments so they can be manually removed, or actually implement proper inline image support for plain text composition. All of these are a lot of work however, and since it half works in the context people would likely expect it to, it's probably best to bump this from 0.12 for now.
Niels, I realize now that the mailchimp email does not have inline images: all jpg instances in the source are part of external urls. So my comment 6 was incorrect: Geary is/was behaving well!
Mike, I've just made a test on an email sent from a friend who uses Apple. There's a tricky behaviour here when I forward the message: The inline image *seems* to be preserved *even if composer is set to plain text*, because it's displayed in the composer. But then the image is not included. It is included only if I enable rich text, as you said.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new ticket at https://gitlab.gnome.org/GNOME/geary/-/issues/ Thank you for your understanding and your help.