After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710618 - Window layout adjustments
Window layout adjustments
Status: RESOLVED OBSOLETE
Product: quadrapassel
Classification: Applications
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: quadrapassel-maint
quadrapassel-maint
Depends on:
Blocks:
 
 
Reported: 2013-10-22 09:24 UTC by Allan Day
Modified: 2018-05-22 12:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshots (485.21 KB, image/png)
2013-10-22 11:27 UTC, Allan Day
  Details
Screenshot of current build (17.73 KB, image/png)
2013-11-20 12:12 UTC, Mario Wenzel
  Details
Show the clutterembed inside an aspectframe (1.07 KB, patch)
2014-10-22 19:03 UTC, Robert Roth
committed Details | Review
Dim labels based on designer review (1.76 KB, patch)
2014-10-22 19:35 UTC, Robert Roth
committed Details | Review

Description Allan Day 2013-10-22 09:24:34 UTC
Some obvious issues with the layout of the window:

 * The block preview area should always be visible when it is enabled (this gives stability and predictability to the window)

 * The block preview area needs a heading to make it clear what it is. "Next" is the conventional label.

 * Score, lines and level could look much nicer - I would suggest arranging them vertically, with different font sizes and colours (see mockup)

 * The padding to each side of the score / line / level adjusts as you change the width of the window. This results in odd looking padding. I would keep the padding between the game area and the details fixed. If possible, the padding to the right hand side of the details should only be adjusted when maximising.


https://raw.github.com/gnome-design-team/gnome-mockups/master/games/quadrapassel/quadrapassel.png
Comment 1 Mario Wenzel 2013-10-22 11:02:13 UTC
"The block preview area should always be visible when it is enabled (this
gives stability and predictability to the window)"

Isn't this the case? In master and 3.10, the preview area is removed if the preview is disabled or hard block mode is enabled (this dependency is made clear by disabling the preview-checkbox on enabling hard block mode).

Having the preview area enabled but showing no preview was considered a bug and fixed in https://bugzilla.gnome.org/show_bug.cgi?id=700720 / https://bugzilla.gnome.org/show_bug.cgi?id=669624

With that in mind, could you go into more detail how this design should be implemented?

Mario
Comment 2 Allan Day 2013-10-22 11:27:08 UTC
Created attachment 257837 [details]
screenshots

(In reply to comment #1)
> "The block preview area should always be visible when it is enabled (this
> gives stability and predictability to the window)"
> 
> Isn't this the case?

Hi Mario! Sorry, I could have been clearer - I was referring to the initial state before you start playing. After you have started, the preview area appears and the score, lines and level details move down.
Comment 3 Mario Wenzel 2013-11-17 21:15:42 UTC
I work on that as we go along.

I changed the text layout of the sidebar and the preview area is now always visible if it is enabled (only when it is available). The changes have just been pushed to master and you can look at it right now and it will also be included in the next unstable release (3.11.2) tomorrow.

Mario
Comment 4 Mario Wenzel 2013-11-20 12:10:33 UTC
Even though the whole layout change will take some time, I've added a frame to the preview area that says "Next:". I think this is an improvement. This change will be in 3.11.3. I will attach a screenshot of the current build.
Comment 5 Mario Wenzel 2013-11-20 12:12:08 UTC
Created attachment 260294 [details]
Screenshot of current build
Comment 6 Allan Day 2013-11-20 13:12:48 UTC
(In reply to comment #5)
> Created an attachment (id=260294) [details]
> Screenshot of current build

Looks great! I gave master a try a few days ago and it is really good.

Removing the colons after the heading labels, and dimming them (making the color a bit darker) would look better.
Comment 7 Robert Roth 2014-10-22 19:03:35 UTC
Created attachment 289167 [details] [review]
Show the clutterembed inside an aspectframe
Comment 8 Robert Roth 2014-10-22 19:35:49 UTC
Created attachment 289168 [details] [review]
Dim labels based on designer review
Comment 9 Mario Wenzel 2014-10-24 14:27:39 UTC
Review of attachment 289168 [details] [review]:

This works fine :)
Comment 10 Mario Wenzel 2014-10-24 14:27:46 UTC
Review of attachment 289167 [details] [review]:

This works fine :)
Comment 11 GNOME Infrastructure Team 2018-05-22 12:29:42 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/quadrapassel/issues/10.