After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700720 - Preview field shouldn't be shown when preview is disabled
Preview field shouldn't be shown when preview is disabled
Status: RESOLVED FIXED
Product: quadrapassel
Classification: Applications
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: quadrapassel-maint
quadrapassel-maint
Depends on:
Blocks:
 
 
Reported: 2013-05-20 14:20 UTC by Mario Wenzel
Modified: 2013-05-22 20:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch hiding preview embed (1.53 KB, patch)
2013-05-20 14:25 UTC, Mario Wenzel
committed Details | Review

Description Mario Wenzel 2013-05-20 14:20:29 UTC
As it says on the tin.

As discussed in Bug 669624 (https://bugzilla.gnome.org/show_bug.cgi?id=669624), when preview mode is disabled (either because of "hard block mode" or manually disabling preview mode), the preview window should not be shown.
Comment 1 Mario Wenzel 2013-05-20 14:25:32 UTC
Created attachment 244783 [details] [review]
Patch hiding preview embed
Comment 2 Michael Catanzaro 2013-05-22 20:03:00 UTC
Review of attachment 244783 [details] [review]:

Looks good.
Comment 3 Michael Catanzaro 2013-05-22 20:15:10 UTC
Yay it's fixed, thanks Mario!

https://git.gnome.org/browse/quadrapassel/commit/?id=d9cb3197470089cac14be053a080f935d406a6df