GNOME Bugzilla – Bug 710464
Add support for new ATK roles
Last modified: 2013-11-18 18:51:04 UTC
ATK now has ATK_ROLE_TITLE_BAR (see bug 709351) and is about to get a new role for blockquotes (see bug 710463). AT-SPI2 (and pyatspi) will need to add support for these new roles.
Created attachment 257941 [details] [review] Adds title-bar and block-quote role
Comment on attachment 257941 [details] [review] Adds title-bar and block-quote role This looks fine. Thanks for the patch.
Created attachment 258473 [details] [review] at-spi2-atk patch for title_bar and block_quote role NOTE: not sure if the bump on at-spi2-core is correct, as at-spi2-core 2.11.1 still doesn't include those roles.
Created attachment 258476 [details] [review] pyatspi2 patch for title bar and block quote roles addition
Created attachment 259284 [details] [review] at-spi2-core support for TITLE_BAR, BLOCK_QUOTE, AUDIO and video audio and video were just added on ATK (bug 711558). As this patch is not committed yet (was waiting for the review of the other bugs) I prefered to include them on one patch, instead of submit an add-on.
Created attachment 259285 [details] [review] at-spi2-atk support for TITLE_BAR, BLOCK_QUOTE, AUDIO and VIDEO roles
Created attachment 259286 [details] [review] pyatspi2 support for TITLE_BAR, BLOCK_QUOTE, AUDIO and VIDEO roles
Comment on attachment 258473 [details] [review] at-spi2-atk patch for title_bar and block_quote role Yeah, the at-spi dependency should really be 2.11.2, and I should have bumped the version in at-spi2-core after releasing. Feel free to bump the version when you commit.
Comment on attachment 258476 [details] [review] pyatspi2 patch for title bar and block quote roles addition Looks good. Thanks.
Comment on attachment 259284 [details] [review] at-spi2-core support for TITLE_BAR, BLOCK_QUOTE, AUDIO and video These basically seem fine, although the atk dependency really should be 2.11.2, but atk's version needs to be bumped. At-spi2-core has the same issue.
(In reply to comment #10) > (From update of attachment 259284 [details] [review]) > These basically seem fine, although the atk dependency really should be 2.11.2, > but atk's version needs to be bumped. At-spi2-core has the same issue. Ok, I will commit all this patches as soon as I release atk 2.11.2
Comment on attachment 259285 [details] [review] at-spi2-atk support for TITLE_BAR, BLOCK_QUOTE, AUDIO and VIDEO roles Committed setting the dependency to recently released atk 2.11.2
Comment on attachment 259286 [details] [review] pyatspi2 support for TITLE_BAR, BLOCK_QUOTE, AUDIO and VIDEO roles Committed setting the dependency to recently released atk 2.11.2