GNOME Bugzilla – Bug 709351
New role is needed for header bars
Last modified: 2013-10-18 14:59:37 UTC
We now have GtkHeaderBar which gets exposed as ATK_ROLE_PANEL. Many things get exposed as ATK_ROLE_PANEL so this role is largely useless. It would be nice if ATs like Orca could identify the header bar without having to do heuristic determinations. Having a new accessible role should accomplish that. Proposed options: * ATK_ROLE_HEADER_BAR * ATK_ROLE_TITLE_BAR * anything else in that general ballpark :)
Created attachment 256456 [details] [review] Tentative patch This patch just adds the roles (as everybody can notice now adding a role is easier, after the work on bug 705290). Tentative as probably the documentation can be improved (feedback is welcome). FWIW: about the "since" on the documentation, I will start to do what gtk, clutter and glib does, that is use it to indicate in which stable release it will be available, instead of going to the very deep detail. That would simplify setting those numbers during current cycle.
Thanks for doing this. I'm afraid I wasn't clear in my opening report. I was proposing one of those; not both. ATK_ROLE_HEADER_BAR has the advantage of being consistent with GtkHeaderBar. Alternatively, ATK_ROLE_TITLE_BAR is more consistent with how screen readers tend to refer to the object in question. If we do have a need for both roles, then I think the documentation needs to clearly reflect when to use one and when to use the other.
(In reply to comment #2) > Thanks for doing this. > > I'm afraid I wasn't clear in my opening report. I was proposing one of those; > not both. ATK_ROLE_HEADER_BAR has the advantage of being consistent with > GtkHeaderBar. Alternatively, ATK_ROLE_TITLE_BAR is more consistent with how > screen readers tend to refer to the object in question. If we do have a need > for both roles, then I think the documentation needs to clearly reflect when to > use one and when to use the other. Just pushed a commit adding ATK_ROLE_TITLE_BAR : commit 193abeb56fa98b00be30a334f1a76605013fe230 Author: Alejandro Piñeiro <apinheiro@igalia.com> Date: Fri Oct 4 12:02:11 2013 +0200 role: new role ATK_ROLE_TITLE_BAR https://bugzilla.gnome.org/show_bug.cgi?id=709351 Closing bug.