After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709850 - lose track of missed messages when showing log
lose track of missed messages when showing log
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
: 710047 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-10-10 17:46 UTC by William Jon McCann
Modified: 2013-10-30 05:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
chatView: Add "left-off" indicator (3.96 KB, patch)
2013-10-30 05:11 UTC, Florian Müllner
committed Details | Review

Description William Jon McCann 2013-10-10 17:46:38 UTC
If I have 8 missed messages in a room and I click on the room to view it, the indicator is cleared and I have no way of seeing which 8 messages I missed. Perhaps we should show a line or something to indicate where I left off.
Comment 1 Florian Müllner 2013-10-10 17:51:12 UTC
This is a direct conflict with bug 709842 :-)

We don't show any "left-off" indicator now, but unless all unread messages fit the view (e.g. it's not scrolled), then only the first unread message should get acknowledged when you switch to the room, other messages become read when you scroll them into view.
Comment 2 William Jon McCann 2013-10-10 18:14:57 UTC
It isn't in conflict actually. If we remove the indicator for just channel messages from the sidebar we need the "left off" indicator even more. I think I agree with only using the sidebar indicator for direct messages/mentions.

In concert with that I think we should only "pause" the scrollbar when there are direct messages or mentions. If there are not then we should keep the scrollbar pinned to the bottom and indicate where the last place you saw was with a line or something - in case you want to browse back.
Comment 3 Florian Müllner 2013-10-10 18:27:27 UTC
(In reply to comment #2)
> In concert with that I think we should only "pause" the scrollbar when there
> are direct messages or mentions. If there are not then we should keep the
> scrollbar pinned to the bottom

That's bug 709843 :-)
Comment 4 Florian Müllner 2013-10-13 16:48:39 UTC
*** Bug 710047 has been marked as a duplicate of this bug. ***
Comment 5 Florian Müllner 2013-10-30 05:11:22 UTC
Created attachment 258514 [details] [review]
chatView: Add "left-off" indicator

When coming back to a channel with unread messages, it's hard to
tell where the user left off, in particular now that we only
pause auto-scrolling for highlighted messages. Add a horizontal
line at the left-off position to make reading the backlog easier.
Comment 6 Florian Müllner 2013-10-30 05:29:41 UTC
Attachment 258514 [details] pushed as c8b5f0f - chatView: Add "left-off" indicator