After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708083 - Set each <li> translatable instead of the whole <ul>
Set each <li> translatable instead of the whole <ul>
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
3.9.x
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on: 708039
Blocks:
 
 
Reported: 2013-09-14 18:42 UTC by Baptiste Mille-Mathias
Modified: 2014-07-11 08:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Set each <li> translatable instead of the whole <ul> (1.69 KB, patch)
2013-09-14 18:45 UTC, Baptiste Mille-Mathias 		none Details | Review
appdata: Set each <li> translatable instead of the whole <ul> (1.71 KB, patch)
2014-07-11 08:47 UTC, Debarshi Ray 		committed Details | Review

Description Baptiste Mille-Mathias 2013-09-14 18:42:34 UTC 
+++ This bug was initially created as a clone of Bug #708039 +++

Seems wrong to have markup in translation, instead 
just set text inside <li> to be translatable.
Comment 1 Baptiste Mille-Mathias 2013-09-14 18:45:53 UTC 
Created attachment 254944 [details] [review]
Set each <li> translatable instead of the whole <ul>

Fix bug
Comment 2 Debarshi Ray 2013-09-16 11:14:02 UTC 
For what it is worth, some people think that translating the whole <description> as a single hunk is a better idea than translating each of the smaller tags. It would allow translators more room to write the text in a way that fits better with their language.
Comment 3 Daniel Mustieles 2014-07-09 15:52:17 UTC 
(In reply to comment #2)
> For what it is worth, some people think that translating the whole
> <description> as a single hunk is a better idea than translating each of the
> smaller tags. It would allow translators more room to write the text in a way
> that fits better with their language.

As a translator, it's better to have each <li> element translatable instead of having the hole <description> element, to avoid markup in the translatable string.

Also, this is the "standar way" in the other modules so, please, consider Baptiste's patch as valid, from the point of view of the translators team ;-)

Thanks!
Comment 4 Debarshi Ray 2014-07-11 08:47:09 UTC 
Created attachment 280478 [details] [review]
appdata: Set each <li> translatable instead of the whole <ul>

Rebased against master.
Comment 5 Debarshi Ray 2014-07-11 08:47:45 UTC 
Review of attachment 280478 [details] [review]:

If it is fine with Daniel, it is fine with me!