After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708039 - Set each <li> translatable instead of the whole <ul>
Set each <li> translatable instead of the whole <ul>
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks: 708083
 
 
Reported: 2013-09-13 19:52 UTC by Baptiste Mille-Mathias
Modified: 2014-07-11 08:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Set each li translatable instead of the whole <ul> (1.50 KB, patch)
2013-09-13 19:52 UTC, Baptiste Mille-Mathias 		none Details | Review
appdata: Set each li translatable instead of the whole <ul> (1.59 KB, patch)
2014-07-11 08:51 UTC, Debarshi Ray 		committed Details | Review

Description Baptiste Mille-Mathias 2013-09-13 19:52:30 UTC 
Seems wrong to have markup in translation, instead 
just set text inside <li> to be translatable.
Comment 1 Baptiste Mille-Mathias 2013-09-13 19:52:31 UTC 
Created attachment 254880 [details] [review]
Set each li translatable instead of the whole <ul>
Comment 2 Debarshi Ray 2013-09-16 11:13:41 UTC 
For what it is worth, some people think that translating the whole <description> as a single hunk is a better idea than translating each of the smaller tags. It would allow translators more room to write the text in a way that fits better with their language.
Comment 3 Alexandre Franke 2013-09-16 17:49:57 UTC 
I agree with the explanation given by Debarshi. However we also try to push to not have any markup in strings, so as to avoid possible broken translations. I'm forwarding this bug report to the i18n list to discuss this.
Comment 4 Claude Paroz 2013-09-16 19:35:38 UTC 
Generally, the less markup in translatable strings the better. Sometimes, it might make sense to include the markup where it appears that translators may change the markup in some way, or if the markup is inside sentences (NEVER split sentences). In that particular case, I don't see what translators might change in that list, so I'd favour Baptiste's proposal.
My 2 cents.
Comment 5 Debarshi Ray 2013-09-17 14:14:19 UTC 
So shall we mark the whole of <description> as a single chunk?

I am trying to avoid going to and fro with this because we are in string freeze and soon will be in hard code freeze. Do you think it is worth breaking the freeze for this? Or is it fine to resolve this for 3.12?
Comment 6 Debarshi Ray 2014-07-11 08:51:59 UTC 
Created attachment 280479 [details] [review]
appdata: Set each li translatable instead of the whole <ul>

Rebased against master.
Comment 7 Debarshi Ray 2014-07-11 08:53:07 UTC 
Review of attachment 280479 [details] [review]:

Looks like the majority of translators are leaning in favour of Baptiste (see bug 708083)