After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706731 - New tabs should inherit history of parent.
New tabs should inherit history of parent.
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: History
3.8.x (obsolete)
Other Linux
: Normal enhancement
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks: 755388
 
 
Reported: 2013-08-25 05:47 UTC by Niels L Ellegaard
Modified: 2016-02-09 13:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Make new tabs inherit history of parent (5.31 KB, patch)
2016-01-20 12:33 UTC, Carlos Garcia Campos
committed Details | Review

Description Niels L Ellegaard 2013-08-25 05:47:20 UTC
In earlier versions of epiphany, a new tab would inherit a copy the history of the parent tab. So if I middle clicked to on a link to open  a new tab, then I would end up with two tabs that shared the same history. 

This was useful for tabbed browsing, because the user didn't have to memorize which tab was the parent, and the user wouldn't delete the wrong tab by accident and suddenly lose the ability to go back to a previous page.

BTW: I just fund epiphany 3.8.2 in Debian/Sid. This looks great.
Comment 1 Reinout van Schouwen 2013-08-26 11:49:30 UTC
I can confirm, the history menu on the back button was re-added after 3.0 but the tab history unfortunately didn't come with it.
Comment 2 Michael Catanzaro 2016-01-03 19:17:33 UTC
We'll be able to implement this once we land Carlos's patch in WebKit#115600.
Comment 3 Carlos Garcia Campos 2016-01-14 17:21:47 UTC
Other browsers like firefox or chromium don't do this, or do they have a setting to do it?
Comment 4 Michael Catanzaro 2016-01-14 17:43:38 UTC
I miss this feature, and would like it back even if other browsers don't have it. I actually thought this was why you were working on session state.
Comment 5 Carlos Garcia Campos 2016-01-16 09:47:19 UTC
(In reply to Michael Catanzaro from comment #4)
> I miss this feature, and would like it back even if other browsers don't
> have it. I actually thought this was why you were working on session state.

No, I wanted to keep bf list and scroll position when restoring the ephy session at startup. I'll try to bring this feature back then too.
Comment 6 Carlos Garcia Campos 2016-01-20 12:33:12 UTC
Created attachment 319440 [details] [review]
Make new tabs inherit history of parent
Comment 7 Michael Catanzaro 2016-01-20 19:55:27 UTC
Review of attachment 319440 [details] [review]:

::: src/ephy-window.c
@@ +2355,3 @@
+
+		new_view = ephy_embed_get_web_view (new_embed);
+		if (flags & EPHY_NEW_TAB_APPEND_AFTER)

It feels a bit fragile to rely on EPHY_NEW_TAB_APPEND_AFTER to decide whether to restore state...?
Comment 8 Carlos Garcia Campos 2016-02-09 13:24:01 UTC
Comment on attachment 319440 [details] [review]
Make new tabs inherit history of parent

I had forgotten to push this