After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706623 - its not possible to select an virtual machine with keyboard in selection mode
its not possible to select an virtual machine with keyboard in selection mode
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
3.8.x
Other Linux
: Normal normal
: 3.22
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-08-22 22:24 UTC by chris
Modified: 2016-03-31 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
searchbar: Ignore 'space' & 'enter' when not focused (1.13 KB, patch)
2013-08-28 14:45 UTC, Zeeshan Ali
committed Details | Review

Description chris 2013-08-22 22:24:57 UTC
Hi,
Its not possible in the boxes interface to select an virtual machine with space or enter if i m in selection mode.

if i press space on an virtual machine to select it -> the search bar opens.
Comment 1 chris 2013-08-27 10:08:42 UTC
hi
can someone test ist with the gtk master?
i think this bug is fixt with Bug#706812.
Comment 2 chris 2013-08-27 10:13:17 UTC
sorry i revert my last comment.
sorry i m blind, so its not always easy to overlook everything in the browser.
i see that bug#706812 only fixes in gnome-clocks. 
this bug is realy similar to the bug#706812 
with enter/space it should possible to check the checkbox in selection mode not open the search (like now).
Comment 3 Zeeshan Ali 2013-08-27 23:08:39 UTC
(In reply to comment #0)
> Hi,
> Its not possible in the boxes interface to select an virtual machine with space
> or enter if i m in selection mode.
> 
> if i press space on an virtual machine to select it -> the search bar opens.

I can reproduce the problem with space here but unfortunately space could very well be part of box name so I think that behavior is correct.

Hitting 'Enter' works here for selecting boxes in selection mode btw. Getting the focus on the items after getting into selection mode seems to be unpredictable but that would be a separate issue (that I'll add to my todo). Once you have the focus on the box, hitting enter selects and unselects it. I tried in both 3.8.4 in Fedora 19 and git master.
Comment 4 chris 2013-08-28 08:02:23 UTC
I think it sould possible to select the checkbox in selection mode with space.
This behavior is in every gnome application default and also documented on this way:
https://help.gnome.org/users/gnome-help/stable/keyboard-nav.html.en

gnome-boxes is the only exaption on this (as i know).

in the other hand: why i should start a search with space? and why i need an search button if the search start wihtout pressing it?
in gnome-documents and gnome-clocks (with an similar interface) this also works.
Comment 5 Zeeshan Ali 2013-08-28 13:57:15 UTC
(In reply to comment #4)
> I think it sould possible to select the checkbox in selection mode with space.
> This behavior is in every gnome application default and also documented on this
> way:
> https://help.gnome.org/users/gnome-help/stable/keyboard-nav.html.en
> 
> gnome-boxes is the only exaption on this (as i know).
>
> in the other hand: why i should start a search with space? and why i need an
> search button if the search start wihtout pressing it?
> in gnome-documents and gnome-clocks (with an similar interface) this also
> works.

Oh, sorry I thought I already checked in documents (I must have checked some other bug then) and indeed space works there. I'll check in their sources and find out how to do this right.

Thanks for your patience and quick feedbacks.
Comment 6 Zeeshan Ali 2013-08-28 14:45:31 UTC
Created attachment 253398 [details] [review]
searchbar: Ignore 'space' & 'enter' when not focused

Doing so allows box selection to be toggled through 'enter' & 'space'
keys in selection mode. This makes use more accessible (as in a11y) and
this behavior is consistent with other GNOME apps (e.g Documents) and is
documented here:

https://help.gnome.org/users/gnome-help/stable/keyboard-nav.html.en
Comment 7 Marc-Andre Lureau 2013-08-28 14:51:16 UTC
Review of attachment 253398 [details] [review]:

if it works, that looks ok to me
Comment 8 Zeeshan Ali 2013-08-28 14:58:04 UTC
I tested the patch, yes.

Attachment 253398 [details] pushed as 7a6aa81 - searchbar: Ignore 'space' & 'enter' when not focused