GNOME Bugzilla – Bug 706385
Add a button style for destructive actions
Last modified: 2013-08-20 14:03:48 UTC
Some buttons have negative consequences, and it is helpful to indicate this in their visual style. In the mockups we tend to use a red colour for this. Applications that are already using this style include Clocks and Software, so it makes sense to keep the style in Adwaita.
Created attachment 252382 [details] [review] patch I simply copied the code over from Software.
Review of attachment 252382 [details] [review]: ::: themes/Adwaita/gtk-3.0/gtk-main.css @@ +151,3 @@ +@define-color destructive_action_button_border #9d4242; +@define-color destructive_action_button_fg @theme_base_color; +@define-color destructive_action_button_shadow shade(@destructive_action_button_border, 1.15); There should be a dark theme equivalent defined for these in gtk-main-dark.css @@ +190,3 @@ * WM * ******/ +@define-color wm_title shade(@theme_fg_color,1.8); This change doesn't belong to this patchset. ::: themes/Adwaita/gtk-3.0/gtk-widgets.css @@ +80,3 @@ + color: @unfocused_insensitive_fg_color; +} + Most of the changes in this file look like the result of a merge conflict of some sort, and should be backed out.
Created attachment 252407 [details] [review] updated patch Looks like a managed to include some of Jakub's window theme changes. This looks better.
Review of attachment 252407 [details] [review]: Other than the comment below, this looks fine to me. ::: themes/Adwaita/gtk-3.0/gtk-main-dark.css @@ +141,3 @@ +@define-color destructive_action_button_border #9d4242; +@define-color destructive_action_button_fg @theme_base_color; +@define-color destructive_action_button_shadow shade(@destructive_action_button_border, 1.15); These colors are the same as in the bright theme - if that's intended, we have another file (gtk-main-common.css) that is included by both themes and holds color defines common to both, and these should be moved there.
Created attachment 252424 [details] [review] updated patch Moves the colors to gtk-main-common.css. They work well enough in both the light and dark variants.
Review of attachment 252424 [details] [review]: Looks good!
Comment on attachment 252424 [details] [review] updated patch Pushed: https://git.gnome.org/browse/gnome-themes-standard/commit/?id=c9fd43eee9913c689dfbad90f8e0736fc9efb99b Thanks for your help, Cosimo!