After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706381 - Use standard css styles for buttons
Use standard css styles for buttons
Status: RESOLVED FIXED
Product: gnome-clocks
Classification: Applications
Component: general
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: Clocks maintainer(s)
Clocks maintainer(s)
Depends on: 706385
Blocks:
 
 
Reported: 2013-08-20 11:18 UTC by Allan Day
Modified: 2013-08-20 14:10 UTC
See Also:
GNOME target: ---
GNOME version: 3.9/3.10

Attachments
initial patch (15.52 KB, patch)
2013-08-20 11:28 UTC, Allan Day 		none Details | Review
updated patch (26.52 KB, patch)
2013-08-20 11:48 UTC, Allan Day 		none Details | Review
updated patch (28.25 KB, patch)
2013-08-20 12:43 UTC, Allan Day 		committed Details | Review

Description Allan Day 2013-08-20 11:18:16 UTC 
Right now, Clocks defines the colors for the stopwatch and timer buttons. It would be better to use standard styles from Adwaita.
Comment 1 Allan Day 2013-08-20 11:28:24 UTC 
Created attachment 252375 [details] [review]
initial patch

This replaces "clocks-go" with "suggested-action". We need to get "destructive-action" into Adwaita to fix the second half.
Comment 2 Allan Day 2013-08-20 11:48:35 UTC 
Created attachment 252383 [details] [review]
updated patch

New patch, which depends on getting "destructive-action" into Adwaita (bug 706385).

gnome-clocks.css still has a bunch of sections for linked buttons, which might need to be removed as well.
Comment 3 Allan Day 2013-08-20 12:43:07 UTC 
Created attachment 252409 [details] [review]
updated patch

This one removes the border assets from gnome-clocks.gresource.xml, and takes out the unnecessary linked button styling from the css.
Comment 4 Paolo Borelli 2013-08-20 13:38:48 UTC 
Review of attachment 252409 [details] [review]:

Looks good! Please push...

I guess now that we do not have assets we could even consider pushing the css in gnome-theme-standard.
Another tiny bit that should be generalized in adwaita is the bottom bar in the selection mode