GNOME Bugzilla – Bug 706353
About box changes size when license button is toggled on, link to website is wrong
Last modified: 2013-08-22 16:37:55 UTC
The GNOME Wiki has some changes a few days ago, so the link to the "website" of GNOME Music is now "https://wiki.gnome.org/Apps/Music". Also the about box changes size when the license is shown, it doesn't happen with Totem for example. We might need to lessen the words per line (though I don't think that's a good idea - this part is translatable so it might happen to translations too, and the font there is not monospace so it would be hard to get it right).
Another improvement would be to alphabetize the designers. The maintainers and contributors are currently alphabetized.
I did some changes in bug #706457 that affects this.
Created attachment 252513 [details] [review] Fix the upstream URL in the "about" dialog
Comment on attachment 252513 [details] [review] Fix the upstream URL in the "about" dialog The following fix has been pushed: 36b15bb Fix the upstream URL in the "about" dialog
Created attachment 252515 [details] [review] Fix the upstream URL in the "about" dialog This in fact fixes the URL in the configure.ac file, and then reuses that in the "about" dialog. If it needs to change in the future, then it can be changed only in one place.
Now what remains are the following fixes for the About dialog: - Add a newline after the Contributors list to separate it with the Designers list - List designers alphabetically - Remove newlines in the license (GNU follows a convention of two spaces after dots) - Enable wrapping of license
Created attachment 252762 [details] [review] fix formatting in Credits and License
The following fix has been pushed: 2199f3a Fix formatting in About dialog I modified the patch: - I removed a line in the patch which prevents the dialog to be modal (hint property) - Added newlines per section and removed some newlines missed - Removed my notes to the commit message and a comment Thanks for fixing this bug! :D
Created attachment 252773 [details] [review] Fix formatting in About dialog - Add a newline after the Contributors list to separate it with the Designers list - List designers alphabetically - Remove newlines in the license - Enable wrapping of license