GNOME Bugzilla – Bug 706457
Invalid copyright headers
Last modified: 2013-08-21 08:30:22 UTC
All the files in gnomemusic/*.py contain the following: # Gnome Music is free software; you can Public License as published by the # Free Software Foundation; either version 2 of the License, or (at your # option) any later version. A few words are missing in the first line. ---------- Note: I had already reported this problem back in the days when g-m was written in Javascript. It had been fixed, and then the problem reappeared when g-m was rewritten in Python. That probably means that someone is copy-pasting from a place which has the same problem, so you might want to track that and fix it as well. ;)
Created attachment 252508 [details] [review] Fixes for license notices There are some missing words from the license notices, so added them in. The non-GPL compatible GStreamer plugins exception is also added to the license notices. Changed "Music" to "GNOME Music" in the license shown in the About box.
Yes, it is my fault - I told Emily to use the older license notices from the JavaScript files which don't have the said fix. Could please you check the following patch? Just for the reference, I changed instances of "Gnome Music" with "GNOME Music". I prefer to use this one, because it is what the Brand Guidelines uses (https://wiki.gnome.org/BrandGuidelines) and this is what we used during the announcement of the first release. The discussion for these issues are in https://mail.gnome.org/archives/marketing-list/2010-April/msg00031.html
The following fix has been pushed: 216ae3a Fixes for license notices This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Created attachment 252510 [details] [review] Fixes for license notices There are some missing words from the license notices, so added them in. The non-GPL compatible GStreamer plugins exception is also added to the license notices. Changed "Music" to "GNOME Music" in the license shown in the About box.