After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704435 - media-keys: Add a binding to take a short screencast of the screen
media-keys: Add a binding to take a short screencast of the screen
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
: 700098 (view as bug list)
Depends on:
Blocks: 700099 700100 704436
 
 
Reported: 2013-07-18 04:46 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-08-15 00:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
media-keys: Add a binding to take a short screencast of the screen (7.48 KB, patch)
2013-07-18 04:46 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-07-18 04:46:23 UTC 
Now that we have a DBus API in gnome-shell, we can move the screencast
binding over here.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-07-18 04:46:25 UTC 
Created attachment 249464 [details] [review]
media-keys: Add a binding to take a short screencast of the screen
Comment 2 Bastien Nocera 2013-07-18 07:36:31 UTC 
Review of attachment 249464 [details] [review]:

Looks good. You'll need a separate patch to gnome-control-center if you want it to show up in the keyboard shortcuts panel.

::: plugins/media-keys/gsd-media-keys-manager.c
@@ +1995,3 @@
+        g_dbus_proxy_call (manager->priv->screencast_proxy,
+                           "Screencast",
+                           /* Translators: this is a filename used for screencast recording */

Can you give an example output? (eg. what do %d and %t correspond to in the C locale)
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-07-18 07:43:14 UTC 
I should probably point out that this is practically the same as bug #700098. I'll coordinate with Florian about which one to go with.

(In reply to comment #2)
> Looks good. You'll need a separate patch to gnome-control-center if you want it
> to show up in the keyboard shortcuts panel.

Ah, yeah, I forgot that that wasn't automatic.

> Can you give an example output? (eg. what do %d and %t correspond to in the C
> locale)

"Screencast from 07-17-2013 10:00:46 PM.webm"

Date and time.
Comment 4 Bastien Nocera 2013-07-18 07:49:25 UTC 
*** Bug 700098 has been marked as a duplicate of this bug. ***
Comment 5 Bastien Nocera 2013-07-18 07:50:53 UTC 
(In reply to comment #3)
> I should probably point out that this is practically the same as bug #700098.
> I'll coordinate with Florian about which one to go with.

Your patch is pretty much the same as his, but yours has the translated filename.

> (In reply to comment #2)
> > Looks good. You'll need a separate patch to gnome-control-center if you want it
> > to show up in the keyboard shortcuts panel.
> 
> Ah, yeah, I forgot that that wasn't automatic.
> 
> > Can you give an example output? (eg. what do %d and %t correspond to in the C
> > locale)
> 
> "Screencast from 07-17-2013 10:00:46 PM.webm"

Please add it to the translators comment. Good to go after that.
Comment 6 Jasper St. Pierre (not reading bugmail) 2013-08-15 00:42:51 UTC 
Attachment 249464 [details] pushed as 1ae70dc - media-keys: Add a binding to take a short screencast of the screen