After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700100 - Remove recorder component
Remove recorder component
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 704436 (view as bug list)
Depends on: 700098 704435
Blocks:
 
 
Reported: 2013-05-10 17:40 UTC by Florian Müllner
Modified: 2013-08-15 00:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove recorder component (7.01 KB, patch)
2013-05-10 17:40 UTC, Florian Müllner 		accepted-commit_now Details | Review

Description Florian Müllner 2013-05-10 17:40:28 UTC 
With the screencast API from bug 696247, we can let g-s-d handle the screencast shortcut (like we do for screenshots).
Comment 1 Florian Müllner 2013-05-10 17:40:31 UTC 
Created attachment 243815 [details] [review]
Remove recorder component

With the screencast DBus API in place, the built-in recorder shortcut
can be handled in gnome-settings-daemon's media-keys plugin like other
shortcuts (most notably the screenshot ones).
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-05-10 17:51:06 UTC 
Review of attachment 243815 [details] [review]:

Seems your patch here has a rogue gvc submodule update. Fix that and everything's fine.

::: data/50-gnome-shell-screenshot.xml.in
@@ +5,3 @@
+     an older version of this file from the system and crashing
+     (due to the now-invalid GSettings key), we keep installing
+     this stub for the time being ...

ugh. Do we have a g-c-c bug for this?
Comment 3 Florian Müllner 2013-05-10 18:00:37 UTC 
(In reply to comment #2)
> ::: data/50-gnome-shell-screenshot.xml.in
> @@ +5,3 @@
> +     an older version of this file from the system and crashing
> +     (due to the now-invalid GSettings key), we keep installing
> +     this stub for the time being ...
> 
> ugh. Do we have a g-c-c bug for this?

I'm not sure there is a bug - g-c-c picks up keybinding files from all XDG_DATA_DIRS (looks right to me), but will not load files with a basename that has been loaded already from an earlier directory (looks good to me as well). Or do you mean g-c-c should check all schemas/keys before using them?
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-05-10 18:37:01 UTC 
Hm. I guess crashing is the right thing to do there, unless we can convince jhbuild to not stuff system dirs in XDG_DATA_DIRS, but that's iffy.
Comment 5 drago01 2013-05-11 11:55:23 UTC 
(In reply to comment #4)
> Hm. I guess crashing is the right thing to do there ...

No.
Comment 6 Florian Müllner 2013-05-11 12:15:26 UTC 
(In reply to comment #5)
> (In reply to comment #4)
> > Hm. I guess crashing is the right thing to do there ...
> 
> No.

For what it's worth, I read that as "it's up to us to not crash g-c-c", e.g. keep the patch as-is (minus the accidental gvc bump)
Comment 7 drago01 2013-07-18 06:00:13 UTC 
*** Bug 704436 has been marked as a duplicate of this bug. ***
Comment 8 Jasper St. Pierre (not reading bugmail) 2013-07-18 06:14:31 UTC 
Wow, huh, it seems we practically wrote the same exact patches... How did I forget about this.