After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704203 - gnome-panel white background instead of gradient color.
gnome-panel white background instead of gradient color.
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on: 704019
Blocks:
 
 
Reported: 2013-07-14 16:37 UTC by Alberts Muktupāvels
Modified: 2013-09-26 03:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
possible fix for this bug (1.33 KB, patch)
2013-07-15 20:51 UTC, Alberts Muktupāvels
none Details | Review
gnome-panel improvements... (3.70 KB, patch)
2013-07-19 20:58 UTC, Alberts Muktupāvels
none Details | Review
Only last hunk of proposed attachment #251305 (981 bytes, patch)
2013-09-26 03:42 UTC, Philipp
rejected Details | Review

Description Alberts Muktupāvels 2013-07-14 16:37:58 UTC
Overview:
In ubuntu with gnome-session-fallback gnome-panel has white background instead of gradient color. Ambiance theme. It works if I downgrade gtk to version 3.6.x. So I am thinking that it could be regression with gtk, but maybe I am wrong. If so, can someone of gtk devs comment on this? I would love to hear about changes made to gtk and probably some info on how to fix gnome-panel.

Steps to Reproduce:
Download latest available ubuntu development release, install gnome-session-fallback. When logged in, you will see white color instead of gradient. 

Gradient will show up when open panel properties, switch to background tab. Change from none to solid color, than back from solid color to none. gradient shows up.

Actual Results:
Gnome panel has white color as background.

Expected Results:
Gnome panel with gradient as background.
Comment 1 Jeremy Bicha 2013-07-14 17:29:13 UTC
This doesn't affect Adwaita. Please ask the developers of your theme to make their theme compatible with GTK 3.8.

https://bugs.launchpad.net/ubuntu/+source/ubuntu-themes/+bug/1196177
Comment 2 Alberts Muktupāvels 2013-07-14 18:01:14 UTC
Yes, it doesn't affect Adwaita, because it doesn't use gradient for gnome-panel. Installed gnome-themes-standard, changed gtk theme to adwaita, gnome-panel got simple black color as background.
Comment 3 Jeremy Bicha 2013-07-14 18:31:21 UTC
OK, reassigning to gnome-panel as there's still not enough information here to say that this is a GTK bug.
Comment 4 Alberts Muktupāvels 2013-07-15 20:51:11 UTC
Created attachment 249240 [details] [review]
possible fix for this bug

This change fixed problem for me. I did not see any side effects with this change. But maybe it needs more testing.
Comment 5 Alberts Muktupāvels 2013-07-16 09:52:28 UTC
Ok, I was wrong, it dosn' t fix problem... :( I guess it is realy not gnome-panel bug. There is nothing wrong with default_pattern in panel-background.c. It is always passed to gdk_window_set_background_pattern.
Comment 6 Alberts Muktupāvels 2013-07-19 20:58:25 UTC
Created attachment 249663 [details] [review]
gnome-panel improvements...

Fix gnome-panel background (this bug);
Fix gnome-panel creation under two or more separate x screens (https://bugzilla.gnome.org/show_bug.cgi?id=704019)
Comment 7 Alberts Muktupāvels 2013-08-11 20:44:18 UTC
Correct patch is attached to this bug - https://bugzilla.gnome.org/show_bug.cgi?id=704019. It will fix this bug too.
Comment 8 Philipp 2013-09-26 03:38:03 UTC
Please post seperate patches for seperate bugs, if at all possible. Extracting the missing hunk from attachment #251305 [details] now...
Comment 9 Philipp 2013-09-26 03:42:34 UTC
Created attachment 255792 [details] [review]
Only last hunk of proposed attachment #251305 [details]
Comment 10 Philipp 2013-09-26 03:51:40 UTC
Comment on attachment 255792 [details] [review]
Only last hunk of proposed attachment #251305 [details]

Disregard this patch; Alberts _had_ sent in a seperate patch, which was actually included in the 3.8.0 release as commit https://git.gnome.org/browse/gnome-panel/commit/?id=ce8b3fcb101d1795bb3ab99f767e60b44f4a08e8 .
He just hadn't attached it here, which caused me to be confused.
Comment 11 Philipp 2013-09-26 03:53:12 UTC
Fixed in 3.8.0; closing.