GNOME Bugzilla – Bug 704019
Create gnome-panel and its objects on correct screen when using separate x screens.
Last modified: 2013-09-26 03:13:33 UTC
Created attachment 248947 [details] [review] Patch with fix for described problem/bug Currently when using gnome panel with separate x screens (two or more) on first start gnome-panel's are created on all screens, but all objects are created on first screen panels: 1) First screen has duplicated objects 2) Second, Third, ... screen panels are empty. Attached patch with fix.
Created attachment 249664 [details] [review] gnome-panel improvements... Fix gnome-panel background (https://bugzilla.gnome.org/show_bug.cgi?id=704203); Fix gnome-panel creation under two or more separate x screens (this bug)
Review of attachment 249664 [details] [review]: ::: gnome-panel.orig/gnome-panel/panel-widget.c @@ -1574,3 +1574,3 @@ { panel_widget_set_background_default_style (widget); - GTK_WIDGET_CLASS (panel_widget_parent_class)->style_updated (widget); + //GTK_WIDGET_CLASS (panel_widget_parent_class)->style_updated (widget); What was that line for? Will there be any regressions if we remove it?
(In reply to comment #2) > Review of attachment 249664 [details] [review]: > > ::: gnome-panel.orig/gnome-panel/panel-widget.c > @@ -1574,3 +1574,3 @@ > { > panel_widget_set_background_default_style (widget); > - GTK_WIDGET_CLASS (panel_widget_parent_class)->style_updated (widget); > + //GTK_WIDGET_CLASS (panel_widget_parent_class)->style_updated > (widget); > > What was that line for? Will there be any regressions if we remove it? Commenting out /removing that line is needed to fix background bug. Link to bug in launchpad - https://bugs.launchpad.net/ubuntu/+source/ubuntu-themes/+bug/1196177 Doing that I don't see any regression using ubuntu 13.10. When I switched theme to Adwaita I didn't see any regression too, but it was only for some minutes to see if I didn't break anything.
Looks like that line is needed to correctly handle style changes. Did you try changing theme (i.e. Ambiance <-> Adwaita) or changing panel background in Preferences? Does setting colored, transparent or image background still work?
(In reply to comment #4) > Looks like that line is needed to correctly handle style changes. Than what that line actually is doing? > Did you try changing theme (i.e. Ambiance <-> Adwaita) or changing > panel background in Preferences? Yes, I did. > Does setting colored, transparent or image background still work? 1. Using Ambiance theme I can change to colored background, I can set even it transparent, I can set image as background. 2. Using Tweak Tool I can change to Adwaita. I can set color or image as background. Same as with Ambiance. 3. Changing Adwaita to Ambiance makes gnome-panel to restart / crash. Is this related?
Created attachment 251305 [details] [review] gnome-panel improvements... While searching in google about style_updated I found that gimp first calls to style_updated and than do rest things. So I give a try, changed order of these lines: panel_widget_set_background_default_style (widget); GTK_WIDGET_CLASS (panel_widget_parent_class)->style_updated (widget); Gnome panel still works, bug fixed and no need to remove line. To be sure that bug is fixed by this change, I installed version without this patch, and white panels was back. Reinstalled pached version - everything is working.
Seems that bug was simple. First we set our background than with style_updated we draw background-color over our gradient background. So all themes was affected, but we simply didn't see it. Background color was draw over same background color. Why this happens only with gtk3.8?
Thank you for your patch, committed for 3.8.0: http://git.gnome.org/browse/gnome-panel/commit/?id=3261131e2f3c93fe6238c2d3c7f7f40a14ec7969 Unfortunately, that commit was missing the panel-widget.c hunk from the patch you submitted here. However, as this has nothing to do with this bug and only affects bug #704203, let's discuss that there. Marking this bug as fixed.