GNOME Bugzilla – Bug 703358
java-atk-wrapper can't be re-automake with automake 1.13
Last modified: 2015-02-27 16:56:42 UTC
Hello, I haven't found a category for the java-atk-wrapper. This is about version 0.30.4. With automake 1.13, one gets: automake: warnings are treated as errors automake: warning: autoconf input should be named 'configure.ac', not 'configure.in' /usr/share/automake-1.13/am/ltlibrary.am: warning: 'libatk-wrapper.la': linking libtool libraries using a on-POSIX /usr/share/automake-1.13/am/ltlibrary.am: archiver requires 'AM_PROG_AR' in 'configure.in' jni/src/Makefile.am:1: while processing Libtool library 'libatk-wrapper.la' wrapper/Makefile.am:4: warning: wildcard $(ALL_CLASSES: non-POSIX variable name wrapper/Makefile.am:4: (probably a GNU make extension) wrapper/org/GNOME/Accessibility/Makefile.am:1: warning: wildcard $(srcdir: non-POSIX variable name wrapper/org/GNOME/Accessibility/Makefile.am:1: (probably a GNU make extension) wrapper/org/GNOME/Accessibility/Makefile.am:2: warning: patsubst %.java,%.class,$(JAVA_SRC: non-POSIX variable name wrapper/org/GNOME/Accessibility/Makefile.am:2: (probably a GNU make extension) wrapper/org/GNOME/Accessibility/Makefile.am:3: warning: patsubst $(srcdir: non-POSIX variable name wrapper/org/GNOME/Accessibility/Makefile.am:3: (probably a GNU make extension) wrapper/org/GNOME/Accessibility/Makefile.am:13: warning: '%'-style pattern rules are a GNU make extension autoreconf: automake failed with exit status: 1
(In reply to comment #0) > Hello, > > I haven't found a category for the java-atk-wrapper. at-spi has a component for java-atk-wrapper. Moving to proper product:component
I noted some compiler error when I went to do some work on this module a while ago. I think I fixed that (or came close to it) at the time but then had to go and do some work and never had time to follow through. I'll check how far I got (and if I still have the folder) when I get a minute but from memory it was mostly a fair amount errors arising from needing to be updated to find all the relevant stuff it needs. I am not sure why the rpm versions of this are able to build ok without problems when it has these problems from source though. I'll see if can try it out over the week and notice I get the same errors or not then.
(In reply to comment #0) > Hello, > > I haven't found a category for the java-atk-wrapper. This is about > version 0.30.4. With automake 1.13, one gets: > > automake: warnings are treated as errors > > automake: warning: autoconf input should be named 'configure.ac', not > 'configure.in' Definately remember that one actually. It had only to be changed as recommended and any references to the new file changed too, of course.
Created attachment 275821 [details] [review] Sort the first basic set of configuration problems I was not able to find the original fixes I did so I just cloned a fresh version and fixed the initial problems for now. The posix problems are caused by the % syntax and whilst I do vaguely remember what I did I will need to check each error again before I can fix those as it is not something I know what to do with off the top of my head. I should have something within a week or so but am in the middle of exams so I figure this first patch fixing the basics should not be held up by that one. They are not really problems relate to each other anyway. Please take a look.
Created attachment 275838 [details] [review] Fix Compilation errors Ok this patch seems to fix things for me. I am a little uncertain whether my approach is the best course of action, but since it has saved a total wrapper/org/GNOME/Accessibility/Makefile.am rewrite from being needed to compile the module completely, then it seems like a good start. See what you think.
Review of attachment 275838 [details] [review]: Just tested it, and I got it compiling, so seems that most of the stuff is mostly solved. Thanks for the patch. The patch looks good, except for a small thing. See below. ::: configure.ac @@ +30,3 @@ +AC_CONFIG_MACRO_DIR([m4]) + +m4_define([req_ver_atk], [2.12.0]) Why you pushed the atk requirement from 1.17.0 to 2.12.0? Bumping up a dependency is only needed if the wrapper is using atk API only available on an atk which version is greater that 1.17.0. And AFAIK, that is not the case. In fact I just tried to put back 1.17.0, and it worked fine. Am I missing something?
(In reply to comment #6) > Review of attachment 275838 [details] [review]: > > Just tested it, and I got it compiling, so seems that most of the stuff is > mostly solved. Thanks for the patch. > > The patch looks good, except for a small thing. See below. > > ::: configure.ac > @@ +30,3 @@ > +AC_CONFIG_MACRO_DIR([m4]) > + > +m4_define([req_ver_atk], [2.12.0]) Yep you're right. > > Why you pushed the atk requirement from 1.17.0 to 2.12.0? Bumping up a > dependency is only needed if the wrapper is using atk API only available on an > atk which version is greater that 1.17.0. And AFAIK, that is not the case. In > fact I just tried to put back 1.17.0, and it worked fine. Am I missing > something? I'll make the change.
Created attachment 275994 [details] [review] Fix Compilation errors
Thanks for the review. All done now I think
Review of attachment 275994 [details] [review]: Looks good. Thanks for the patch.
(In reply to comment #10) > Review of attachment 275994 [details] [review]: > > Looks good. Thanks for the patch. As I wanted to test and close bug 684442, I already committed this patch in your behalf (don't worry, the credentials would show you as the author). So closing the bug. Again, thanks for the patch.
No problem. Thanks for the reviews.
[Moving at-spi/java-atk-wrapper bugs to separate product. See bug 740075]