GNOME Bugzilla – Bug 684442
Support use of JAVACFLAGS during build
Last modified: 2015-02-27 16:57:14 UTC
Created attachment 224817 [details] [review] Patch to add JAVACFLAGS Ubuntu Quantal has switched default java implementation to openjdk-7; as a result java-atk-wrapper (which builds with the default jdk) no longer builds backwards compatible code - which is required to support use with openjdk-6. This patch adds the JAVACFLAGS option to the build process to allow flags to be passed to javac (in this case I'm using "-source 1.5 -target 1.5").
Created attachment 224818 [details] [review] Git formatted version of patch
[Mass-resetting default assignee, see bug 705890. Please reclaim this bug report by setting the assignee to yourself if you still plan to work on this. Thanks!]
Review of attachment 224818 [details] [review]: Seems fine but I am not sure why you needed to remove this test to solve the problem: if test "x$with_jdk_auto_detect" = "xyes";
(In reply to comment #3) > Review of attachment 224818 [details] [review]: > > Seems fine but I am not sure why you needed to remove this test to solve the > problem: > > if test "x$with_jdk_auto_detect" = "xyes"; The patch doesn't remove that line. If you take a look to configure.in after applying the patch, you would find that the line is still there. What the patch has is this line: @@ -85,7 +87,7 @@ if test "x$with_jdk_auto_detect" = "xyes"; then In spite of that '-' symbol, it doesn't mean that is a removal line. It just indicate how much of the code is shown, to give context to the change. In any case, I agree that in general the patch seems fine. In any case, I was not able to test it due bug 703358
(In reply to comment #4) > (In reply to comment #3) > > Review of attachment 224818 [details] [review] [details]: > > > > Seems fine but I am not sure why you needed to remove this test to solve the > > problem: > > > > if test "x$with_jdk_auto_detect" = "xyes"; > > The patch doesn't remove that line. If you take a look to configure.in after > applying the patch, you would find that the line is still there. > > What the patch has is this line: > @@ -85,7 +87,7 @@ if test "x$with_jdk_auto_detect" = "xyes"; then > > In spite of that '-' symbol, it doesn't mean that is a removal line. It just > indicate how much of the code is shown, to give context to the change. > > In any case, I agree that in general the patch seems fine. In any case, I was > not able to test it due bug 703358 Thanks for clarifying. It was not the patch diff that had me confused but the bugzilla review colour coding which had the line highlighted blue on the left and missing on the right I think this caught me out before once too so I'll be sure to check the raw patch in future and see I am interpreting things right. The review diffs will take some getting used to I think so cheers for helping out.
Im not able to test the patch for this bug due bug 703358. Adding dependency.
(In reply to comment #6) > Im not able to test the patch for this bug due bug 703358. Adding dependency. This bug was solved. I was able to test the patch, and it works, in the sense that the module still compiles (test the module itself is still WIP). So pushing the patch, and closing the bug. Thanks for the patch.
[Moving at-spi/java-atk-wrapper bugs to separate product. See bug 740075]