After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702940 - Heuristics for detecting client-side caching (ncache) in x11vnc
Heuristics for detecting client-side caching (ncache) in x11vnc
Status: RESOLVED DUPLICATE of bug 702926
Product: vinagre
Classification: Applications
Component: VNC
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: vinagre-maint
vinagre-maint
Depends on:
Blocks:
 
 
Reported: 2013-06-24 02:18 UTC by rainwoodman
Modified: 2013-06-24 03:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch x11vnc ncache heuristics first draft (4.78 KB, patch)
2013-06-24 02:19 UTC, rainwoodman
none Details | Review

Description rainwoodman 2013-06-24 02:18:43 UTC
x11vnc has a client-side caching protocol, which is described in:

http://www.karlrunge.com/x11vnc/faq.html#faq-client-caching

It is compatible to most vnc clients, but in order to make use of it, the client needs to be able to crop the vnc frame buffer to the real screen size.

This patch implements some heuristics to correctly crop screen size, 
  * if scaling is enabled, and
  * the height of the frame buffer is much larger than the width of the frame buffer.

  the number of ncache is found by finding the server-side aspect ratio minimizes the cost function:
  
  (h * AspectRatio) / w - (int) (h * AspectRatio / w)

Three aspect ratios are tried: 4 / 3, 16 / 9 and 16 / 10.

There should be a configuration flag to disable this, which is not included in this patch.

It was developed based on the 3.4.2 tag (current version in Fedora 17), but applies cleanly (compilation untested) to the master.
Comment 1 rainwoodman 2013-06-24 02:19:09 UTC
Created attachment 247585 [details] [review]
patch x11vnc ncache heuristics first draft
Comment 2 André Klapper 2013-06-24 03:10:22 UTC

*** This bug has been marked as a duplicate of bug 702926 ***