After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702926 - Heuristics for detecting client-side caching (ncache) in x11vnc
Heuristics for detecting client-side caching (ncache) in x11vnc
Status: RESOLVED OBSOLETE
Product: vinagre
Classification: Applications
Component: VNC
git master
Other Linux
: Normal enhancement
: ---
Assigned To: vinagre-maint
vinagre-maint
: 702927 702929 702930 702932 702933 702934 702935 702936 702937 702938 702939 702940 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-06-24 02:10 UTC by rainwoodman
Modified: 2021-05-26 09:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch x11vnc ncache heuristics first draft (4.78 KB, patch)
2013-06-24 02:10 UTC, rainwoodman
none Details | Review

Description rainwoodman 2013-06-24 02:10:27 UTC
Created attachment 247578 [details] [review]
patch x11vnc ncache heuristics first draft

x11vnc has a client-side caching protocol, which is described in:

http://www.karlrunge.com/x11vnc/faq.html#faq-client-caching

It is compatible to most vnc clients, but in order to make use of it, the client needs to be able to crop the vnc frame buffer to the real screen size.

This patch implements some heuristics to correctly crop screen size, 
  * if scaling is enabled, and
  * the height of the frame buffer is much larger than the width of the frame buffer.

  the number of ncache is found by finding the server-side aspect ratio minimizes the cost function:
  
  (h * AspectRatio) / w - (int) (h * AspectRatio / w)

Three aspect ratios are tried: 4 / 3, 16 / 9 and 16 / 10.

There should be a configuration flag to disable this, which is not included in this patch.

It was developed based on the 3.4.2 tag (current version in Fedora 17), but applies cleanly (compilation untested) to the master.
Comment 1 André Klapper 2013-06-24 03:09:55 UTC
*** Bug 702927 has been marked as a duplicate of this bug. ***
Comment 2 André Klapper 2013-06-24 03:09:58 UTC
*** Bug 702929 has been marked as a duplicate of this bug. ***
Comment 3 André Klapper 2013-06-24 03:10:01 UTC
*** Bug 702930 has been marked as a duplicate of this bug. ***
Comment 4 André Klapper 2013-06-24 03:10:05 UTC
*** Bug 702932 has been marked as a duplicate of this bug. ***
Comment 5 André Klapper 2013-06-24 03:10:22 UTC
*** Bug 702940 has been marked as a duplicate of this bug. ***
Comment 6 André Klapper 2013-06-24 03:10:24 UTC
*** Bug 702939 has been marked as a duplicate of this bug. ***
Comment 7 André Klapper 2013-06-24 03:10:27 UTC
*** Bug 702938 has been marked as a duplicate of this bug. ***
Comment 8 André Klapper 2013-06-24 03:10:31 UTC
*** Bug 702937 has been marked as a duplicate of this bug. ***
Comment 9 André Klapper 2013-06-24 03:10:34 UTC
*** Bug 702936 has been marked as a duplicate of this bug. ***
Comment 10 André Klapper 2013-06-24 03:10:37 UTC
*** Bug 702935 has been marked as a duplicate of this bug. ***
Comment 11 André Klapper 2013-06-24 03:10:40 UTC
*** Bug 702934 has been marked as a duplicate of this bug. ***
Comment 12 André Klapper 2013-06-24 03:10:43 UTC
*** Bug 702933 has been marked as a duplicate of this bug. ***
Comment 13 rainwoodman 2013-06-24 03:18:06 UTC
Sorry Andre, I was receiving a lot of 504 gateway timeout errors!
Comment 14 André Klapper 2021-05-26 09:25:52 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version of Vinagre, then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new enhancement request ticket at
  https://gitlab.gnome.org/GNOME/vinagre/-/issues/

Thank you for your understanding and your help.