After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701411 - Implement search
Implement search
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other Linux
: High normal
: 3.12
Assigned To: gnome-music-maint
gnome-music-maint
Depends on: 703261
Blocks:
 
 
Reported: 2013-06-01 10:36 UTC by Allan Day
Modified: 2014-04-15 22:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Implements the searchbar (4.32 KB, patch)
2013-06-27 15:42 UTC, Shivani Poddar
committed Details | Review

Description Allan Day 2013-06-01 10:36:31 UTC
Searching for music is useful. :) Wireframes for how search should work, including how it should interact with selection mode:

https://raw.github.com/gnome-design-team/gnome-mockups/master/music/wire-search.png
Comment 1 Shivani Poddar 2013-06-27 15:42:42 UTC
Created attachment 247919 [details] [review]
Implements the searchbar

Based ontop of the "search" branch in the server repo.
Comment 2 Vadim Rutkovsky 2013-06-27 15:58:48 UTC
Setting this as assigned to Shivani.

Good job, generally works, a couple of bugs and TODOs:

Bugs:
 1) * Open search bar
    * Select any album/artist/switch views
    Then search bar disappears

 2) Doesn't search by artist name on albums view

Todo:
 1) Songs view: the search filters songs but doesn't take this in account for playback
 2) Album view: filter tracks by title on album view
 3) Artists view: when artist is selected, filter selected tracks/albums by title
Comment 3 Vadim Rutkovsky 2013-06-27 16:07:09 UTC
Review of attachment 247919 [details] [review]:

Thanks, pushed as 918b75316b9855fe8c02e7af666735747d1a5ff1
Comment 4 Vadim Rutkovsky 2013-08-27 12:55:44 UTC
Still actual after python port
Comment 5 Arnel Borja 2013-09-12 15:47:52 UTC
Implemented as filtering for now in 3.10.
Comment 6 Vadim Rutkovsky 2014-04-15 22:26:21 UTC
Closing, as search (as filtering) is implemented. A better search will be implemented as a part of a fix for bug 724021