After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701279 - Long filename text overlaps other icons on hover
Long filename text overlaps other icons on hover
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Views: Icon View
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-05-30 14:31 UTC by Michael Wood
Modified: 2013-11-24 23:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot of too long filename (62.40 KB, image/png)
2013-05-30 14:31 UTC, Michael Wood 		  Details
nautilus-overlappingtext.patch (1.02 KB, patch)
2013-11-04 17:51 UTC, manuel.BACHMANN@eurogiciel.fr 		needs-work Details | Review
nautilus-overlappingtext.patch (468 bytes, patch)
2013-11-19 14:02 UTC, manuel.BACHMANN@eurogiciel.fr 		accepted-commit_now Details | Review
CanvasItem: fix overlapping filenames on hover (963 bytes, patch)
2013-11-24 23:53 UTC, Michael Catanzaro 		committed Details | Review

Description Michael Wood 2013-05-30 14:31:08 UTC 
Created attachment 245648 [details]
Screenshot of too long filename

Long files names text seem to overlap on hover in the icon view.
Comment 1 manuel.BACHMANN@eurogiciel.fr 2013-11-04 17:51:54 UTC 
Created attachment 258944 [details] [review]
nautilus-overlappingtext.patch

Please consider attached patch, which fixes this by not expanding the icon text anymore when it is highlighted (but just renamed, with F2 e.g.).
Comment 2 Cosimo Cecchi 2013-11-16 02:35:52 UTC 
Review of attachment 258944 [details] [review]:

I don't think this is entirely correct - we still want the text expanding in all the other scenarios (where it will usually be rendered white with a blue background below).

::: libnautilus-private/nautilus-canvas-item.c
@@ -816,3 @@
 
-	if (needs_highlight ||
-	    details->is_prelit ||

I think this is actually the only line that should be removed - all the other conditions are still needed for legitimate reasons.
Comment 3 manuel.BACHMANN@eurogiciel.fr 2013-11-19 14:02:11 UTC 
Created attachment 260240 [details] [review]
nautilus-overlappingtext.patch

Agreed, I removed too much in my initial patch.

Attached is a new one, which only targets pre-focus highlighting, as you suggested.
Comment 4 Cosimo Cecchi 2013-11-19 16:40:15 UTC 
Review of attachment 260240 [details] [review]:

Thanks, this looks good to me!
Comment 5 Michael Catanzaro 2013-11-24 23:53:03 UTC 
The following fix has been pushed:
308f4ce CanvasItem: fix overlapping filenames on hover
Comment 6 Michael Catanzaro 2013-11-24 23:53:06 UTC 
Created attachment 261380 [details] [review]
CanvasItem: fix overlapping filenames on hover