GNOME Bugzilla – Bug 700596
Edit->Modify submenu is not documented
Last modified: 2013-05-20 19:11:17 UTC
Created attachment 244649 [details] [review] Patch to update doc/C/gui-menus.xml and doc/C/data-types.xml The version 1.12 Gnumeric Manual includes Modify in group 3 of the Edit menu items, but does not describe it. As a result, it appears that there is no documentation in the Manual of how to define new names or to determine or modify the definitions of existing names. NOTE: This is a duplicate of bug 700131, which has been marked resolved as a duplicate of generic documentation bug 663482. I don't know if it does any good to attach a proposed patch to a resolved bug, so I'm creating a new one. The attachment adds documentation for all the Edit > Modify submenu entries and updates the Insert menu documentation for Comment and Hyperlink to reflect that they can also be used to initiate editing of an existing comment or link.
When I apply your patch I don't get the new png file. Could you attach that file to this bug report please? It would also be nice to have the appropriate Changelog and News entries.
Created attachment 244669 [details] Define Names dialog image Sorry about the missing image file - I was under the impression that "git format-patch" had included it in the patch file.
Created attachment 244671 [details] [review] Proposed NEWS and ChangeLog entries. This is my first attempt at submitting changes to Gnumeric; suggestions for improvement are welcome.
Review of attachment 244671 [details] [review]: The Changelog entries are in the wrong file. They should be in doc/C/Changelog. (I know having various Changelog files in various directories (but not all directories) is confusing. The entries should always be in the closest Changelog file in a ancestor directory.
Created attachment 244685 [details] [review] Revised NEWS and ChangeLog entries. I never thought to look for a second ChangeLog. In moving the ChangeLog entry, I realized that two files weren't mentioned; that is also fixed.
I have committed your patches (with some tiny changes: in NEWS names are listed alphabetically). Thank you very much for providing them! I think the names section in the menu description is really to long. SOmetime in the future we should introduce a specific section describing names and how to edit and paste them and then move all the names info there. The menu (and formula) descriptions could then just refer to that section. This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
I just did a "git pull", and the new doc/C/figures/menu-edit-modify-names.png didn't show up. Should I be concerned?