After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700458 - optionally open notes in new window when double clicked
optionally open notes in new window when double clicked
Status: RESOLVED FIXED
Product: gnote
Classification: Applications
Component: main
git master
Other Linux
: Normal normal
: ---
Assigned To: gnote-maint
gnote-maint
: 702447 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-05-16 13:12 UTC by Adam Dingle
Modified: 2013-06-24 14:53 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Adam Dingle 2013-05-16 13:12:54 UTC
In the current Gnote build, when I double click a note it opens in the same window, which resizes to the note's size.  I actually prefer the old behavior (found in Gnote 3.6 at least), in which a note appears in its own window.  I know I can right click and choose Open in New Window, but I'd like this to happen when I double click.

So it would be nice to have a preference or, at the very least, a GSettings key that makes notes open in separate windows.
Comment 1 Aurimas Černius 2013-05-17 19:06:50 UTC
Makes sence.
I think GSettings key is the right thing for a start, a UI in preferences dialog could be added later, if there really is a need for one.
Comment 2 Luc Pi 2013-05-31 02:39:08 UTC
I personally like to keep the option of multiple windows, one per note, when opening. A setting would be a good start!

Also suggesting:
==> when opened from the status icon menu, always open in a NEW WINDOW
--> when opened from the main window, open in the same window


About the window size change, it is inherent. The content of a note is very different from the content of the main window.

I am thinking to a visual transition effect to avoid the "jumping"
window size. The file chooser opens by expanding vertically, and
closes by collapsing vertically. For Gnote, when selecting a note, the
main window could collapse vertically, then open the note by expanding
horizontally. Then we don't really see the change in width/height.
Comment 3 Aurimas Černius 2013-06-17 13:30:49 UTC
*** Bug 702447 has been marked as a duplicate of this bug. ***
Comment 4 Aurimas Černius 2013-06-17 18:40:46 UTC
I've made that tray always opens new windows. I also refactored some old stuff,
so please let me know of any issues.

Always open note in new window will be a configurable option.
Comment 5 Luc Pi 2013-06-18 02:16:09 UTC
smoke test did not show any issue.

I would think that ESC should close the window.
There is the "back" button to switch the main window

So the use case: "I am busy with something, i want to take some notes about something else", has minimal key strokes:
- click tray
- click note
- write
- ESC
Comment 6 Aurimas Černius 2013-06-20 11:49:46 UTC
I've added GSettings key for this. Have a look and see if haven't missed any place.
There are two issues left:
- ESC doesn't close the note window, it switches to search (in this mode it should close it)
- This option should be in preferences dialog
Comment 7 Aurimas Černius 2013-06-20 13:31:04 UTC
I've implemented the ESC handling too, see if it work fine in all cases.
Comment 8 Adam Dingle 2013-06-21 02:57:35 UTC
Thanks, Aurimas - I've set the new GSettings key so that notes open in a new window, which is a behavior I like.

Here's one oddity.  When I open a note, the note window appears directly over the main Gnote window.  To be more specific, the note window appears where the main Gnote window was when I started Gnote - if I move the main window, new notes still appear in the same location.  For me this is unexpected, since I've told my window manager (Compiz) that I always want new windows to be centered, and all windows in other programs normally appear at the center of the display.  I'm not sure how much control you have over this, but I'd prefer that you leave placing of note windows to the window manager.  (And if you do want to explicitly place them near the main Gnote window, you should be updating the new window placement position when the Gnote window moves.)
Comment 9 Aurimas Černius 2013-06-22 11:29:40 UTC
> Here's one oddity.  When I open a note, the note window appears directly over
> the main Gnote window.  To be more specific, the note window appears where the
> main Gnote window was when I started Gnote - if I move the main window, new
> notes still appear in the same location.  For me this is unexpected, since I've

Gnote saves window position for main window and each note. I'm thinking about either the ability to disable it or to remove this feature entirely. That's a separate issue anyway.
Comment 10 Adam Dingle 2013-06-22 12:02:35 UTC
If Gnote is trying to save the window position for each note then that is broken, at least for me:

1. Make sure that the dconf key open-notes-in-new-window is selected.
2. Double click a note to open it.
3. Move the note window to a new position.
4. Close the note window.
5. Double click the same note to open it again.  It will open at the position where it appeared in step 2, not the position you moved it to in step 3.
Comment 11 Aurimas Černius 2013-06-24 14:53:10 UTC
Added checkbox in preferences to enable this feature.
As for window placement, it's out of scope for this bug and I intend to remove it, leaving window positioning for window manager.