GNOME Bugzilla – Bug 699571
Remove PyGBindingWeakRef
Last modified: 2013-10-14 22:23:42 UTC
The addition of the "unbind" method on GBinding (g_binding_unbind) should allow us to remove this and rely on introspection to supply it.
Created attachment 243241 [details] [review] Remove PyGObjectWeakRef now that g_binding_unbind exists Remove the static code for managing GBinding references now that GLib has a method for clearing a binding.
Created attachment 243266 [details] [review] Remove PyGObjectWeakRef now that g_binding_unbind exists Remove the static code for managing GBinding references now that GLib has a method for clearing a binding.
Comment on attachment 243266 [details] [review] Remove PyGObjectWeakRef now that g_binding_unbind exists Might need work depending on the outcome of bug 698018
Created attachment 248324 [details] [review] Remove PyGObjectWeakRef now that g_binding_unbind exists Remove the static code for managing GBinding references now that GLib has a method for clearing a binding. Add safe backwards compatible Binding class in which "unbind" raises when called more than once.
Comment on attachment 248324 [details] [review] Remove PyGObjectWeakRef now that g_binding_unbind exists I understand this would bump the glib requirement to 2.37.x? Traditionally we have kept the development version of pygobject working on the stable glib/g-i (except new tests, which we skip with old g-i). I won't veto if you want to push it now, but please consider the above. Also, this needs to go with bumping the glib required version in configure.ac either way.
Pushed now that we depend on GLib > 2.37. Attachment 248324 [details] pushed as 799989a - Remove PyGObjectWeakRef now that g_binding_unbind exists