After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690397 - Replace static Object.bind_property with introspection version
Replace static Object.bind_property with introspection version
Status: RESOLVED OBSOLETE
Product: pygobject
Classification: Bindings
Component: introspection
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on: 675726 690394 699571
Blocks:
 
 
Reported: 2012-12-18 07:25 UTC by Simon Feltman
Modified: 2018-01-10 20:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add reference counting tests for Object.bind_property (3.45 KB, patch)
2012-12-18 10:25 UTC, Simon Feltman
none Details | Review
Add reference counting tests for Object.bind_property (3.45 KB, patch)
2012-12-18 10:31 UTC, Simon Feltman
committed Details | Review

Description Simon Feltman 2012-12-18 07:25:54 UTC
GObject.Object.bind_property is statically exposed in gi/_gobject/pygobject.c. This can be replaced by introspection versions of bind_property and bind_property_full with annotation fixes and some compatibility overrides. In testing the introspection based bind_property, I'm also seeing a reference leak which might be related to bug 675726. So this will also need to be resolved.
Comment 1 Simon Feltman 2012-12-18 10:25:04 UTC
Created attachment 231791 [details] [review]
Add reference counting tests for Object.bind_property

This adds testing for reference counts of transform callbacks and user_data which we will need to ensure works correctly in the introspection implementation.
Comment 2 Simon Feltman 2012-12-18 10:31:38 UTC
Created attachment 231792 [details] [review]
Add reference counting tests for Object.bind_property

Fixed typo
Comment 3 Martin Pitt 2012-12-18 11:06:40 UTC
Comment on attachment 231792 [details] [review]
Add reference counting tests for Object.bind_property

Thanks Simon, this looks good! I assume this fails right now because of bug 675726? When you commit this, can you please add an @unittest.expectedFailure with a reference to that bug?
Comment 4 Simon Feltman 2012-12-18 11:43:59 UTC
Comment on attachment 231792 [details] [review]
Add reference counting tests for Object.bind_property

Thanks Martin.
The tests work in the current static bindings and won't need to be skipped. This gives us a target for how the introspection bindings should minimally behave.
Comment 5 GNOME Infrastructure Team 2018-01-10 20:21:26 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/pygobject/issues/40.