GNOME Bugzilla – Bug 690397
Replace static Object.bind_property with introspection version
Last modified: 2018-01-10 20:21:26 UTC
GObject.Object.bind_property is statically exposed in gi/_gobject/pygobject.c. This can be replaced by introspection versions of bind_property and bind_property_full with annotation fixes and some compatibility overrides. In testing the introspection based bind_property, I'm also seeing a reference leak which might be related to bug 675726. So this will also need to be resolved.
Created attachment 231791 [details] [review] Add reference counting tests for Object.bind_property This adds testing for reference counts of transform callbacks and user_data which we will need to ensure works correctly in the introspection implementation.
Created attachment 231792 [details] [review] Add reference counting tests for Object.bind_property Fixed typo
Comment on attachment 231792 [details] [review] Add reference counting tests for Object.bind_property Thanks Simon, this looks good! I assume this fails right now because of bug 675726? When you commit this, can you please add an @unittest.expectedFailure with a reference to that bug?
Comment on attachment 231792 [details] [review] Add reference counting tests for Object.bind_property Thanks Martin. The tests work in the current static bindings and won't need to be skipped. This gives us a target for how the introspection bindings should minimally behave.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/pygobject/issues/40.