After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699371 - Gtk-WARNING **: Attempting to add a widget with type GtkImage to a GtkButton, but as a GtkBin subclass a GtkButton can only contain one widget at a time; it already contains a widget of type GtkLabel
Gtk-WARNING **: Attempting to add a widget with type GtkImage to a GtkButton,...
Status: RESOLVED OBSOLETE
Product: cheese
Classification: Applications
Component: general
3.4.x
Other Linux
: Normal normal
: 3.8
Assigned To: Cheese Maintainer(s)
Cheese Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-05-01 10:14 UTC by Paul Menzel
Modified: 2013-05-01 11:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Paul Menzel 2013-05-01 10:14:15 UTC 
Using Debian Sid/unstable with Cheese 3.4.2-2, starting it from a terminal the following warnings are printed.

    $ cheese

    (cheese:23523): Gtk-WARNING **: Attempting to add a widget with type GtkImage to a GtkToggleButton, but as a GtkBin subclass a GtkToggleButton can only contain one widget at a time; it already contains a widget of type GtkLabel

    (cheese:23523): Gtk-WARNING **: Attempting to add a widget with type GtkImage to a GtkToggleButton, but as a GtkBin subclass a GtkToggleButton can only contain one widget at a time; it already contains a widget of type GtkLabel

    (cheese:23523): Gtk-WARNING **: Attempting to add a widget with type GtkImage to a GtkToggleButton, but as a GtkBin subclass a GtkToggleButton can only contain one widget at a time; it already contains a widget of type GtkLabel

    (cheese:23523): Gtk-WARNING **: Attempting to add a widget with type GtkImage to a GtkButton, but as a GtkBin subclass a GtkButton can only contain one widget at a time; it already contains a widget of type GtkLabel

    (cheese:23523): Gtk-WARNING **: Attempting to add a widget with type GtkGrid to a GtkToggleButton, but as a GtkBin subclass a GtkToggleButton can only contain one widget at a time; it already contains a widget of type GtkLabel

    (cheese:23523): Gtk-WARNING **: Attempting to add a widget with type GtkImage to a GtkButton, but as a GtkBin subclass a GtkButton can only contain one widget at a time; it already contains a widget of type GtkLabel
Comment 1 David King 2013-05-01 10:20:35 UTC 
This was fixed in 3.5.3 (commits 83e80258949e446a7c03d9cafea2fbf422b55e90 and 4cb11731e62b51c684993e43000c933ea97785c2). Please upgrade to a more recent version of Cheese.
Comment 2 Paul Menzel 2013-05-01 10:49:48 UTC 
David, thank you for your quick reply. I searched for the warning on the Web but the GNOME BTS item did not show up. This one because there warning is not pasted and the GtkBuilder one (bug #671912 [1]), because a whole bunch of bug reports contain the warning.

I even cloned the Cheese git repository, but `git log -i --grep=gtk-warning` did not return any results. One argument for always pasting the whole error message in commit messages. ;-)

David, three more questions.

1. Why did not you resolve this bug as a duplicate? Because two commits are needed to fix this?

2. Unfortunately, Debian Wheezy will stay with GNOME 3.4 and Cheese 3.4 as it is in deep freeze and release is planned next weekend. Reading the discussion of bug #671913 [2], it looks like you consider this change too invasive and you’d prefer Debian should keep the warning to not change the UI that late?

3. What should distributions do in the future? Can newer Cheese versions work fine with an older GNOME stack? So should Debian have kept GNOME 3.4 but upgrade to Cheese 3.6?

[1] https://bugzilla.gnome.org/show_bug.cgi?id=671912
[2] https://bugzilla.gnome.org/show_bug.cgi?id=671913
Comment 3 David King 2013-05-01 11:26:09 UTC 
(In reply to comment #2)
> David, thank you for your quick reply. I searched for the warning on the Web
> but the GNOME BTS item did not show up. This one because there warning is not
> pasted and the GtkBuilder one (bug #671912 [1]), because a whole bunch of bug
> reports contain the warning.

I seem to remember that bugzilla.gnome.org has a robots.txt which requests that search engines do not index it:

http://bugzilla.gnome.org/robots.txt

I think that it was possible for search engine crawlers to cause greatly increased load, but that might not be the case any more.

> I even cloned the Cheese git repository, but `git log -i --grep=gtk-warning`
> did not return any results. One argument for always pasting the whole error
> message in commit messages. ;-)

Thank you for being detailed in your initial report. I do not normally include error messages in my commit messages.

> 1. Why did not you resolve this bug as a duplicate? Because two commits are
> needed to fix this?

Correct.

> 2. Unfortunately, Debian Wheezy will stay with GNOME 3.4 and Cheese 3.4 as it
> is in deep freeze and release is planned next weekend. Reading the discussion
> of bug #671913 [2], it looks like you consider this change too invasive and
> you’d prefer Debian should keep the warning to not change the UI that late?

The change would have broken the GNOME UI freeze if it had been applied to Cheese 3.4. Packaging is the responsibility of the distribution, and I do not consider the fixes invasive, so I leave it up to the distribution on the topic of applying the patches downstream.

> 3. What should distributions do in the future? Can newer Cheese versions work
> fine with an older GNOME stack? So should Debian have kept GNOME 3.4 but
> upgrade to Cheese 3.6?

What distributions do is up to the distribution. Cheese does not normally depend on the latest GNOME libraries, so it is quite possible that Cheese 3.6 will work with a mostly-GNOME 3.4 system, but I do not test that combination.