GNOME Bugzilla – Bug 671913
main: Stop warnings caused by the mode buttons
Last modified: 2013-05-01 10:59:59 UTC
.
Created attachment 209492 [details] [review] main: Stop warnings caused by the mode buttons Once we've set the related action, the label will have been synced, and we won't be able to add an image to the button. Setting "use-action-appearance" to False before setting the related-action works around the problem. See GTK+ bug 671912.
Note that this leaves the prev/next buttons generating warnings as they do use use-action-appearance=True. Easiest way would be to make them follow the action's sensitivity instead of everything (including the label, and "always-show-image").
Comment on attachment 209492 [details] [review] main: Stop warnings caused by the mode buttons Works fine, but this changes the UI by replacing the labels in the mode buttons with images, so will have to wait until after the freeze. You can push it to cheese-next, which I will merge to master after creating the gnome-3-4 branch.
(In reply to comment #3) > (From update of attachment 209492 [details] [review]) > Works fine, but this changes the UI by replacing the labels in the mode buttons > with images Yes, it fixes the bug... I don't see how you could release a 3.4 with this horror of a bug.
(In reply to comment #4) > Yes, it fixes the bug... I don't see how you could release a 3.4 with this > horror of a bug. The mode buttons were the same in Cheese 3.0 and 3.2, and I do not want to change the UI at this late stage.
Meanwhile, Patricia just added a counter when recording... One would pass the freeze break requests, and not the other. The mode buttons are _broken_ in the same way, with the same warnings, in both 3.0 and 3.2. To me, that's not a good enough reason to avoid this patch until then.
(In reply to comment #6) > Meanwhile, Patricia just added a counter when recording... One would pass the > freeze break requests, and not the other. The mode buttons are _broken_ in the > same way, with the same warnings, in both 3.0 and 3.2. To me, that's not a good > enough reason to avoid this patch until then. Patricia's recording timer was added to the cheese-next branch, not master, as it would have broken the feature freeze. I have pushed your patch to cheese-next as well. I do not think that changing the UI at this late stage is worthwhile.
Created attachment 210608 [details] How it looks now. The toolbar looks really, really, wrong right now. Please reconsider asking for a freeze break. Specially if it is not such a big patch anyway.
Comment on attachment 209492 [details] [review] main: Stop warnings caused by the mode buttons Pushed to master as commit 4cb11731e62b51c684993e43000c933ea97785c2, thanks.
Bug #699371 [1] I reported is a duplicate of this one. In the Debian BTS this issue is tracked in Debian bug 696727 [2]. [1] https://bugzilla.gnome.org/show_bug.cgi?id=699371 [2] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=696727