After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697424 - Find does not highlight words when run twice with same search text
Find does not highlight words when run twice with same search text
Status: RESOLVED OBSOLETE
Product: epiphany
Classification: Core
Component: Interface
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks: 755518
 
 
Reported: 2013-04-06 12:42 UTC by Adam Dingle
Modified: 2018-08-03 19:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (1008 bytes, patch)
2013-04-09 12:21 UTC, Manuel Rego Casasnovas 		reviewed Details | Review

Description Adam Dingle 2013-04-06 12:42:05 UTC 
To see the problem:

1. Visit a Web page.
2. Press Ctrl+F and type a word which occurs multiple times on the page.  Epiphany will highlight all instances in yellow.  You can press Enter to jump between them.
3. Press Escape to close the Find bar.
4. Press Ctrl+F again.  Epiphany remembers the previous search term, but does not highlight it on the page.  You can still press Enter to jump between instances, but they aren't highlighted.

I think Epiphany should highlight all instances again when you reopen the Find bar.
Comment 1 Manuel Rego Casasnovas 2013-04-09 12:21:30 UTC 
Created attachment 241054 [details] [review]
Patch

With this patch we fix the issue, but I'm not sure if it's the best approach. I'm forcing a search when opening the toolbar if the find string is not empty.
Comment 2 Claudio Saavedra 2013-06-03 11:44:03 UTC 
Didn't try it, but why not calling webkit_web_view_set_highlight_text_matches() if the text is not empty?
Comment 3 Manuel Rego Casasnovas 2013-08-28 07:44:49 UTC 
(In reply to comment #2)
> Didn't try it, but why not calling webkit_web_view_set_highlight_text_matches()
> if the text is not empty?

That is WK1 API, so we could only use it in that case. I guess we shouldn't add an #ifdef here for this case as we're removing the WK1 bits in the project.
Comment 4 GNOME Infrastructure Team 2018-08-03 19:56:31 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/epiphany/issues/194.